Change in vdsm[master]: Support changing retransmission number and timeout for nfs m...

Saggi Mizrahi has uploaded a new change for review.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................

Support changing retransmission number and timeout for nfs mounts

Parameter validity is done by mount. Valid ranges should be tested for
and implemented in the UI.

Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
---
M vdsm/config.py.in
M vdsm/storage/storage_connection.py
2 files changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/636/1
--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 2: Looks good to me, approved

oops, only now did I see http://gerrit.ovirt.org/681

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Douglas, Saggi, I know NFSv4 is not yet supported by Red Hat's RHEV, but IMO it should
be safe enough to be set via the new API that this patch suggests.

Please consider/address/say why not.

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

Just a note that, if in the future we use nfs via udp these parameters might have a
different values.

Currently, NFSv4 on UDP is not supported.

http://docs.redhat.com/docs/en-US/Red_Hat_Enterprise_Linux/6/html/Storage...

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Ayal Baron has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................




--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 4: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Support changing retransmission number and timeout for nfs mounts

Parameter validity is done by mount. Valid ranges should be tested for
and implemented in the UI.

Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
---
M vdsm/config.py.in
M vdsm/storage/storage_connection.py
2 files changed, 13 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/storage_connection.py
Line 48:         ('timeout', 'timeout', 600))
my resources (=Rami Vaknin) tell me that allowing vers=4 just works. Would you expose this
option, too?

Line 74:     return fileUtils.NFS_OPTIONS + (',timeo=%s,retrans=%s' %
(con['timeout'], con['retrans']))
please be a sport and keep new lines shorter than 80 chars?

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;