Change in vdsm[master]: Support changing retransmission number and timeout for nfs m...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Support changing retransmission number and timeout for nfs mounts
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/storage_connection.py
Line 48:         ('timeout', 'timeout', 600))
my resources (=Rami Vaknin) tell me that allowing vers=4 just works. Would you expose this
option, too?

Line 74:     return fileUtils.NFS_OPTIONS + (',timeo=%s,retrans=%s' %
(con['timeout'], con['retrans']))
please be a sport and keep new lines shorter than 80 chars?

--
To view, visit http://gerrit.ovirt.org/636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4a6f6daa5b14774e03230784b3b2dbe4630e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;