6:38 a.m.
Darshan N has uploaded a new change for review.
Change subject: gluster: Modification of logic for volume capacity calculation.
......................................................................
gluster: Modification of logic for volume capacity calculation.
This patch modifies the logic for gluster volume capacity
computation. Earlier the volume capacity was calculated
wrt non root user. Now logic is modified to calculate
volume capacity wrt root user.
Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129619
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
---
M vdsm/gluster/api.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/31451/1
diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py
index 0e6c850..b9a08e5 100644
--- a/vdsm/gluster/api.py
+++ b/vdsm/gluster/api.py
@@ -205,8 +205,8 @@
replicaCount)
def _computeVolumeStats(self, data):
- total = (data.f_blocks - (data.f_bfree - data.f_bavail)) * data.f_bsize
- free = data.f_bavail * data.f_bsize
+ total = data.f_blocks * data.f_bsize
+ free = data.f_bfree * data.f_bsize
used = total - free
return {'sizeTotal': str(total),
'sizeFree': str(free),
--
To view, visit http://gerrit.ovirt.org/31451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
4:22 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Modification of logic for volume capacity calculation.
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5704/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/69/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3862/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1727/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/31451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
4:04 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: Modification of logic for volume capacity calculation.
......................................................................
gluster: Modification of logic for volume capacity calculation.
This patch modifies the logic for gluster volume capacity
computation. Earlier the volume capacity was calculated
wrt non root user. Now logic is modified to calculate
volume capacity wrt root user.
Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129619
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31451
Reviewed-by: Sahina Bose <sabose(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/gluster/api.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Darshan N: Verified
Dan Kenigsberg: Looks good to me, approved
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
4:04 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: Modification of logic for volume capacity calculation.
......................................................................
Patch Set 1: Code-Review+2
Raising score
--
To view, visit http://gerrit.ovirt.org/31451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:20 a.m.
Sahina Bose has posted comments on this change.
Change subject: gluster: Modification of logic for volume capacity calculation.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:53 a.m.
Darshan N has posted comments on this change.
Change subject: gluster: Modification of logic for volume capacity calculation.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/31451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:50 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Modification of logic for volume capacity calculation.
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10901/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11843/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11686/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/31451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I044e37699d60d1eed2f95eb65189d949c5e4b594
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3563
days inactive
3564
days old
vdsm-patches@lists.fedorahosted.org
6 comments
4 participants
participants (4)
-
Dan Kenigsberg -
dnarayan＠redhat.com -
Jenkins CI RO -
sabose＠redhat.com