Dima Kuznetsov has posted comments on this change.
Change subject: log: Change vdsm log file to enforce user/group
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26728/1/vdsm/logUtils.py
File vdsm/logUtils.py:
Line 166: except:
Line 167: self.handleError(record)
Line 168:
Line 169:
Line 170: class EnforcingWatchedFileHandler(logging.handlers.WatchedFileHandler):
I do not mind using this extra safety measure, but the name of class
must b
Done, hope the new name is better.
Also, could not find a way to use uid/gid with fileConfig (as they are not known at code
generation time), so this class now accepts user name and group name.
Line 171: def __init__(self, uid, gid, *args, **kwargs):
Line 172: self._uid = uid
Line 173: self._gid = gid
Line 174: logging.handlers.WatchedFileHandler.__init__(self, *args, **kwargs)
--
To view, visit
http://gerrit.ovirt.org/26728
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a4d7212cb311b22e4fb60ffdc45163a496a74d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes