Yaniv Bronhaim has posted comments on this change.
Change subject: log: Change vdsm log file to enforce user/group
......................................................................
Patch Set 4:
I wonder:
1. if we need to touch the metadata.log at all which i don't find where we use - dima,
do you see the usage? does really only vdsm user touch this log ?
2. if supervdsm and update logs also should have such check that only root user will be
able to open them
but for now I prefer not to add more noises . this is good enough to avoid the permission
changes we had in the recent past
--
To view, visit
http://gerrit.ovirt.org/26728
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a4d7212cb311b22e4fb60ffdc45163a496a74d6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No