10:20 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: Modify Image.getChain to return a subchain
......................................................................
Modify Image.getChain to return a subchain
The method Image.getChain was returning the entire image chain. Now
it's possible to specify an (optional) volUUID to return a subchain
from the base up to volUUID.
Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
---
M vdsm/storage/image.py
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/3216/1
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
5:56 a.m.
New subject: Change in vdsm[master]: BZ#804640 Modify Image.getChain to return a subchain
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#804640 Modify Image.getChain to return a subchain
......................................................................
BZ#804640 Modify Image.getChain to return a subchain
The method Image.getChain was returning the entire image chain. Now
it's possible to specify an (optional) volUUID to return a subchain
from the base up to volUUID.
Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
---
M vdsm/storage/image.py
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Federico Simoncelli: Verified
Dan Kenigsberg: Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5:56 a.m.
New subject: Change in vdsm[master]: BZ#804640 Modify Image.getChain to return a subchain
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#804640 Modify Image.getChain to return a subchain
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5:04 a.m.
New subject: Change in vdsm[master]: BZ#804640 Modify Image.getChain to return a subchain
Igor Lvovsky has posted comments on this change.
Change subject: BZ#804640 Modify Image.getChain to return a subchain
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:29 a.m.
New subject: Change in vdsm[master]: BZ#804640 Modify Image.getChain to return a subchain
Federico Simoncelli has posted comments on this change.
Change subject: BZ#804640 Modify Image.getChain to return a subchain
......................................................................
Patch Set 2:
In additional I think we can remove getSubChain().
The getSubChain call returns a subchain that might not include the base, so it's
slightly different. I agree that in the future we should converge.
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:29 a.m.
New subject: Change in vdsm[master]: BZ#804640 Modify Image.getChain to return a subchain
Federico Simoncelli has posted comments on this change.
Change subject: BZ#804640 Modify Image.getChain to return a subchain
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:32 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Modify Image.getChain to return a subchain
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Good job Federico. I wanted to do it by my self for
https://bugzilla.redhat.com/show_bug.cgi?id=804640
but you did it first :)
If from some reason you will send an another patchset here
please add the BZ# in the commit message.
In additional I think we can remove getSubChain().
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12:11 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: Modify Image.getChain to return a subchain
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:22 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Modify Image.getChain to return a subchain
......................................................................
Patch Set 1:
Igor, I can't remember if this is exactly what you were working on. If it is and you
have a previous/better version please vote -2 and redirect me to your patch.
--
To view, visit http://gerrit.ovirt.org/3216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8f982fa11fbe140c56b7c9b310b25b8100deeb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4411
days inactive
4415
days old
vdsm-patches@lists.fedorahosted.org
8 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Federico Simoncelli -
Igor Lvovsky -
smizrahi＠redhat.com