Change in vdsm[master]: Added iSER support enabled with a configuration option.

[Roi Dayan]

Roi Dayan has uploaded a new change for review.

Change subject: Added iSER support enabled with a configuration option.
......................................................................

Added iSER support enabled with a configuration option.

When used VDSM will try to connect with iser and fallback
to default on failure.

Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
---
M vdsm/config.py.in
M vdsm/storage/hsm.py
2 files changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/2636/1
--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Added iSER support enabled with a configuration option.
......................................................................


Patch Set 1:

Roi, in my opinion this is acceptable - but you must limit this check to the case where an
interface is not requested by the Engine (initiatorName missing from conDef).

--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Roi Dayan]

Roi Dayan has posted comments on this change.

Change subject: Added iSER support enabled with a configuration option.
......................................................................




--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Added iSER support enabled with a configuration option.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

As I already said on the mailing list, you should add the ability to specify an interface
in the Engine and UI. It makes no sense for VDSM to iterate over interfaces and this
causes unpredictable results on advanced iscsi configurations.

--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Added iSER support enabled with a configuration option.
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Added iSER support enabled with a configuration option.
......................................................................


Added iSER support enabled with a configuration option.

When used VDSM will try to connect with iser and fallback
to default on failure.

Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
---
M vdsm/config.py.in
M vdsm/storage/hsm.py
2 files changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Roi Dayan: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Roi Dayan]

Roi Dayan has posted comments on this change.

Change subject: Added iSER support enabled with a configuration option.
......................................................................


Patch Set 3: Verified; Looks good to me, but someone else must approve

Tested connecting iscsi target without the new configuration option.
Tested connecting iser target with the new configuration option.
Tested connecting iscsi target with the new configuration option.

--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Added iSER support enabled with a configuration option.
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Added iSER support enabled with a configuration option.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 1892:                 # FIXME: remove this call when iface selection is in higher
interface
no need to have this FIXME twice

Line 1908:     def _checkIscsiIface(self, conDef, conObj, conTypeId):
Please find a better name for this function, and give a little docstring telling why it
does what it does.

--
To view, visit http://gerrit.ovirt.org/2636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641745d26be06e172f052a9a4626ac26d2607930
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Roi Dayan <roi.dayan(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;