Change in vdsm[master]: Add TestSecurable safety test

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Add TestSecurable safety test
......................................................................

Add TestSecurable safety test

The test makes sure that all the Securable classes have different
_safety (Event) objects.
The metaclasses are used to generate new types (at import time); the
_safety Event therefore was created only once and inherited by all the
objects created later on.

Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
---
M tests/main.py
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/3150/1
--
To view, visit http://gerrit.ovirt.org/3150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: BZ#807642 Add TestSecurable safety test

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#807642 Add TestSecurable safety test
......................................................................


BZ#807642 Add TestSecurable safety test

The test makes sure that all the Securable classes have different
_safety (Event) objects.
The metaclasses are used to generate new types (at import time); the
_safety Event therefore was created only once and inherited by all the
objects created later on.

Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
---
M tests/main.py
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/3150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#807642 Add TestSecurable safety test

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#807642 Add TestSecurable safety test
......................................................................


Patch Set 4: Verified; Looks good to me, approved

yay! two unit tests!

--
To view, visit http://gerrit.ovirt.org/3150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#807642 Add TestSecurable safety test

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#807642 Add TestSecurable safety test
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

I am not pushing this as of yet, since as it is, a failed test blocks `make rpm`

--
To view, visit http://gerrit.ovirt.org/3150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#807642 Add TestSecurable safety test

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#807642 Add TestSecurable safety test
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/main.py
Line 33:         self.assertNotEqual(id(objA._safety), id(objB._safety))
I think this is tied too much to the (currently broken) implementation.
wouldn't it be better to:

 objA._setSafe()
 objB._setUnsafe()
 assert objA._isSafe()

?

--
To view, visit http://gerrit.ovirt.org/3150
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;