Change in vdsm[master]: BZ#807642 Add TestSecurable safety test
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#807642 Add TestSecurable safety test
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/main.py
Line 33: self.assertNotEqual(id(objA._safety), id(objB._safety))
I think this is tied too much to the (currently broken) implementation.
wouldn't it be better to:
objA._setSafe()
objB._setUnsafe()
assert objA._isSafe()
?
--
To view, visit http://gerrit.ovirt.org/3150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01054ec06fc4da9fa475f667375844e3d346470e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>