Federico Simoncelli has uploaded a new change for review.
Change subject: Remove validateAttachedDomain in detachSD ......................................................................
Remove validateAttachedDomain in detachSD
Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110 --- M vdsm/storage/sp.py 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/2074/1 -- To view, visit http://gerrit.ovirt.org/2074 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Remove validateAttachedDomain from detachSD ......................................................................
Patch Set 2:
I've discussed this with Edu and he managed to convince me that we should not remove this validation (it would only be relevant in case detach is normally issued and fails between removal from the master storage domain and the sd backref), otherwise there is no pool to perform the action.
-- To view, visit http://gerrit.ovirt.org/2074 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Eduardo has posted comments on this change.
Change subject: Remove validateAttachedDomain from detachSD ......................................................................
Patch Set 2: Do not submit
(1 inline comment)
Hate validations!
.................................................... File vdsm/storage/sp.py Line 952: domStatuses = self.getDomains() Please _don't_ remove this. If the domain is not belonging to this pool detachSD will fail and return silently. The error is right here: why is the manager trying to detach a domain that is not belonging to this pool?
-- To view, visit http://gerrit.ovirt.org/2074 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Federico Simoncelli has abandoned this change.
Change subject: Remove validateAttachedDomain from detachSD ......................................................................
Patch Set 2: Abandoned
We don't need this.
-- To view, visit http://gerrit.ovirt.org/2074 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
vdsm-patches@lists.fedorahosted.org