Change in vdsm[master]: Remove validateAttachedDomain from detachSD

Eduardo has posted comments on this change.

Change subject: Remove validateAttachedDomain from detachSD
......................................................................


Patch Set 2: Do not submit

(1 inline comment)

Hate validations!

....................................................
File vdsm/storage/sp.py
Line 952:         domStatuses = self.getDomains()
Please _don't_ remove this.
If the domain is not belonging to this pool detachSD will fail and return silently.
The error is right here: why is the manager trying to detach a domain that is not
belonging to this pool?

--
To view, visit http://gerrit.ovirt.org/2074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;