Change in vdsm[master]: xmlrpc: marshalling of Long type

Antoni Segura Puimedon has posted comments on this change.

Change subject: xmlrpc: marshalling of Long type
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/34856/2/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:

Line 46: 
Line 47: 
Line 48: class BindingXMLRPC(object):
Line 49:     def __init__(self, cif, log, port):
Line 50:         xmlrpclib.Marshaller.dispatch[type(0L)] = (
I'd much rather have you do:

import types # in line 28.

xmlrpclib.Marshaller.dispatch[types.LongType] = (...
Line 51:             lambda _, v, w: w(_STRING_VALUE % v)
Line 52:         )
Line 53:         self.cif = cif
Line 54:         self.log = log


-- 
To view, visit http://gerrit.ovirt.org/34856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56341566e4add6a093ba89eb81e09ee9e7a631b1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes