6:25 p.m.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: storage_connection: fix mount.Mount() argument
......................................................................
storage_connection: fix mount.Mount() argument
Remove additional argument from mount.Mount(), otherwise cannot add new NFS storage.
vdsm log:
==========
Thread-1265:INFO::2011-12-23
17:47:54,285::storage_connection::128::Storage.ServerConnection:(validae(Request to
validate NFS storage server)
Thread-1265:ERROR:2011-12-23
18:47:54,285::storage_connection::291::StoragerServerConnection::(__validadeFileServer)
Error during storage connection validation: __init__() got an unexpected keyword argument
'timeout'
Traceback (most recent call last):
File "/usr/share/vdsm/storage/storage_connection.py", line 264, in
__validateFileServer
TypeError: __init()__ got an unexpected keyword argument 'timeout'
Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
---
M vdsm/storage/storage_connection.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/734/1
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
8:51 a.m.
New subject: Change in vdsm[master]: mount.py: fix __init()__
Dan Kenigsberg has posted comments on this change.
Change subject: mount.py: fix __init()__
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/mount.py
Line 82: def __init__(self, fs_spec, fs_file, timeout=None):
this timeout arg is not used at all, and should not be declared!
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:07 a.m.
New subject: Change in vdsm[master]: mount.py: fix __init()__
Igor Lvovsky has posted comments on this change.
Change subject: mount.py: fix __init()__
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 154: mnt = mount.Mount(con['rp'], mntPath,
timeout=CON_TIMEOUT)
timeout=CON_TIMEOUT is redundant here.
Line 264: mnt = mount.Mount(con['rp'], mountpoint,
timeout=CON_TIMEOUT)
timeout=CON_TIMEOUT is redundant here.
Line 338: return mount.Mount(con['rp'], mntPath, timeout=CON_TIMEOUT)
timeout=CON_TIMEOUT is redundant here.
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:51 p.m.
New subject: Change in vdsm[master]: storage_connection: unexpected keyword 'timeout'
Dan Kenigsberg has posted comments on this change.
Change subject: storage_connection: unexpected keyword 'timeout'
......................................................................
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:41 p.m.
New subject: Change in vdsm[master]: mount.py: fix __init()__
Douglas Schilling Landgraf has posted comments on this change.
Change subject: mount.py: fix __init()__
......................................................................
Patch Set 4:
going to improve the commit message. New version ...
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:49 a.m.
New subject: Change in vdsm[master]: storage_connection: unexpected keyword 'timeout'
Igor Lvovsky has submitted this change and it was merged.
Change subject: storage_connection: unexpected keyword 'timeout'
......................................................................
storage_connection: unexpected keyword 'timeout'
remove from mount.Mount() timeout argument
added to umount() and mount() the timeout argument
vdsm log:
==========
Thread-1265:INFO::2011-12-23
17:47:54,285::storage_connection::128::Storage.ServerConnection:(validae(Request to
validate NFS storage server)
Thread-1265:ERROR:2011-12-23
18:47:54,285::storage_connection::291::StoragerServerConnection::(__validadeFileServer)
Error during storage connection validation: __init__() got an unexpected keyword argument
'timeout'
Traceback (most recent call last):
File "/usr/share/vdsm/storage/storage_connection.py", line 264, in
__validateFileServer
TypeError: __init()__ got an unexpected keyword argument 'timeout'
Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
---
M vdsm/storage/storage_connection.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Igor Lvovsky: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:49 a.m.
New subject: Change in vdsm[master]: storage_connection: unexpected keyword 'timeout'
Igor Lvovsky has posted comments on this change.
Change subject: storage_connection: unexpected keyword 'timeout'
......................................................................
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:35 a.m.
New subject: Change in vdsm[master]: storage_connection: unexpected keyword 'timeout'
Igor Lvovsky has posted comments on this change.
Change subject: storage_connection: unexpected keyword 'timeout'
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:47 p.m.
New subject: Change in vdsm[master]: mount.py: fix __init()__
Dan Kenigsberg has posted comments on this change.
Change subject: mount.py: fix __init()__
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
Commit Message
Line 10: added to umount() and mount() the timer argument
timer-->timeout
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:33 p.m.
New subject: Change in vdsm[master]: mount.py: fix __init()__
Dan Kenigsberg has posted comments on this change.
Change subject: mount.py: fix __init()__
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:37 a.m.
New subject: Change in vdsm[master]: mount.py: fix __init()__
Douglas Schilling Landgraf has posted comments on this change.
Change subject: mount.py: fix __init()__
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:49 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: storage_connection: fix mount.Mount() argument
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 166: mnt.umount(lazy=True)
timeout should probably be moved here
Line 267: mnt.mount(fileUtils.NFS_OPTIONS, mount.VFS_NFS)
timeout should be moved here
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:44 a.m.
Ayal Baron has posted comments on this change.
Change subject: storage_connection: fix mount.Mount() argument
......................................................................
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:41 a.m.
Ayal Baron has posted comments on this change.
Change subject: storage_connection: fix mount.Mount() argument
......................................................................
Patch Set 1: Do not submit
The correct fix is to accept the timeout parameter, not drop it. It is a bug in
Saggi's patches.
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:30 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: storage_connection: fix mount.Mount() argument
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64bf1bd366d1e9cb4c80c50b85a57ae022374cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4541
days inactive
4543
days old
vdsm-patches@lists.fedorahosted.org
14 comments
4 participants
participants (4)
-
abaron＠redhat.com -
Dan Kenigsberg -
Douglas Schilling Landgraf -
Igor Lvovsky