Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

Eduardo has uploaded a new change for review.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................

BZ#736034 - Add metadataignore switch to pvcreate.

Can't be done without Haim's help.

Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
---
M vdsm/storage/lvm.py
1 file changed, 53 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/711/1
--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 4: Verified; Looks good to me, approved

Verified by Haim.

--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 2: Verified

- tested createVG flow
- tested extendVG flow

fix set a place holder in other PVs, which allows, if needed, to perform manual pvmove
between old pv and new one.

also note that if vgcreate command is sent with N devices, then we use only one pvcreate
command with list of pvs and not pvcreate command for each pv like we used to (great scale
improvement).

--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


BZ#736034 - Add metadataignore switch to pvcreate.

We would like to pre-allocate metadata space in all PVs
used for our VGs. However, we are using only the metadata
of the first PV.
This is important for an occasion where the first PV has
to be removed and the metadata it carries has to be copied
into somewhere else.

Could not have been done without Haim's help.

Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
---
M vdsm/storage/lvm.py
1 file changed, 61 insertions(+), 38 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 3: Verified

Verified by Haim

--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 3: Looks good to me, approved

Formerly reviewed internally in http://gerrit.usersys.redhat.com/908

--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(4 inline comments)

....................................................
Commit Message
Line 8: 
please add the motivation for this:

We would like to pre-allocate metadata space in all PVs used for our VGs, however, we are
using only the metadata of the first PV. This is important for an occasion where the first
PV has to be removed and the metadata it carries has to be copied into somewhere else.

Could not have been done without Haim's help.

....................................................
File vdsm/storage/lvm.py
Line 718:     cmd = ["pvcreate", "--metadatasize", metadatasize,
"--metadatacopies", "2", "--metadataignore", "y"]
ELONGLINE

Line 730:             raise se.PhysDevInitializationError("found: %s notFound:
%s", found, notFound)
ELONGLINE

Line 750: def arePartOfVg(pvNames):
vgsOfReachablePvs()

(or find a less-bad name)

"""Return ({pv: vg}, (pv...)) of reachable (and non-reachable
pvs)"""


I prefer a more specific function "getUnavalablePvsForVgs"
that returns a list of "bad" pvs.

--
To view, visit http://gerrit.ovirt.org/711
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;