4:33 p.m.
Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] Rearange code in storage_connection to minimize code duplication
......................................................................
[WIP] Rearange code in storage_connection to minimize code duplication
Change-Id: If3e28c064043f19cefccde13decf6699d2718634
---
M vdsm/storage/storage_connection.py
1 file changed, 144 insertions(+), 227 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/556/1
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
11:11 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Igor Lvovsky has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4:51 p.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Saggi Mizrahi has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:23 p.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Dan Kenigsberg has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:32 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Dan Kenigsberg has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 275: validateDirAccess(con['rp'])
here too, an exception would have been translated to se.StorageServerValidationError.code.
now it is translated to se.StorageServerConnectionError.code.
Line 327: os.unlink(lnPath)
Igor is right: In the former code, an exception here would have caused
rc=se.StorageServerDisconnectionError.code, which is not the case now.
I'm not sure that the old behavior is necessary, but you are breaking it.
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:20 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Igor Lvovsky has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 119: rc = se.StorageServerConnectionError.code
As I mentioned in pathset 1 (that you ignored). It were different error codes (
StorageServerDisconnectionError, StorageServerConnectionError,
StorageServerValidationError) depends of called function. I don't know whether it very
important but RHEV-M pass this error to the user.
Line 120: self.log.error("Error during storage connection operation:
%s", ex, exc_info=True)
Why 'ex' ?
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:43 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Dan Kenigsberg has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
6:13 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Dan Kenigsberg has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
infra-minor
....................................................
File vdsm/storage/storage_connection.py
Line 282: def __validateiSCSIConnection(self, conParams):
the signature of this function should be just like that of __validateLocalConnection.
I now receives a single con. see lines 154-158.
(yeah, talking about this function is stupid)
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:35 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Igor Lvovsky has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/storage_connection.py
Line 119: rc = se.StorageServerConnectionError.code
It is not. It were StorageServerDisconnectionError, StorageServerConnectionError,
StorageServerValidationError.
I don't know whether it very important but RHEV-M pass this error to the user.
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:22 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 119: rc = se.StorageServerConnectionError.code
It was copy pasted originally anyway
Line 282: def __validateiSCSIConnection(self, conParams):
multiple params
Line 284: Validate that we can connect to a storage server.
It was stupid and absurd at the first place
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:59 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: [WIP] Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/storage_connection.py
Line 119: rc = se.StorageServerConnectionError.code
Is it good enoufh? One error code for all connect/disconnect/validate errors.
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:18 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 117: self.log.error("Error during storage connection operation:
%s", ex, exc_info=True)
I know you're only moving code from point to point, but logging 'ex' is
redundant with exc_info=True. And wide lines strains my screen.
maybe log func.__name__ so we can tell which operation has failed?
Line 282: def __validateiSCSIConnection(self, conParams):
a single con
Line 284: Validate that we can connect to a storage server.
gosh, now this docstring (and the function name) is a clear absurd.
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
5:22 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Dan Kenigsberg has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
5:22 a.m.
New subject: Change in vdsm[master]: Rearange code in storage_connection to minimize code duplica...
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Rearange code in storage_connection to minimize code duplication
Change-Id: If3e28c064043f19cefccde13decf6699d2718634
---
M vdsm/storage/storage_connection.py
1 file changed, 149 insertions(+), 228 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4534
days inactive
4551
days old
vdsm-patches@lists.fedorahosted.org
13 comments
3 participants
participants (3)
-
Dan Kenigsberg -
Igor Lvovsky -
smizrahi＠redhat.com