Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 117: self.log.error("Error during storage connection operation:
%s", ex, exc_info=True)
I know you're only moving code from point to point, but logging 'ex' is
redundant with exc_info=True. And wide lines strains my screen.
maybe log func.__name__ so we can tell which operation has failed?
Line 282: def __validateiSCSIConnection(self, conParams):
a single con
Line 284: Validate that we can connect to a storage server.
gosh, now this docstring (and the function name) is a clear absurd.
--
To view, visit
http://gerrit.ovirt.org/556
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>