Dan Kenigsberg has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
infra-minor
....................................................
File vdsm/storage/storage_connection.py
Line 282: def __validateiSCSIConnection(self, conParams):
the signature of this function should be just like that of __validateLocalConnection.
I now receives a single con. see lines 154-158.
(yeah, talking about this function is stupid)
--
To view, visit
http://gerrit.ovirt.org/556
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>