Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 119: rc = se.StorageServerConnectionError.code
It was copy pasted originally anyway
Line 282: def __validateiSCSIConnection(self, conParams):
multiple params
Line 284: Validate that we can connect to a storage server.
It was stupid and absurd at the first place
--
To view, visit
http://gerrit.ovirt.org/556
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>