3:29 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: tests: CountThreadsPlugin
......................................................................
tests: CountThreadsPlugin
Enable this test plugin (via --with-countthreads) to verify that neither
your test, nor the code it tests, leak threads. Unfortunately, this
plugin cannot be enabled by default, since we do have buggy test and
code that do leak.
Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/testValidation.py
M tests/testlib.py
2 files changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/69040/1
diff --git a/tests/testValidation.py b/tests/testValidation.py
index c9b147d..a4b6789 100644
--- a/tests/testValidation.py
+++ b/tests/testValidation.py
@@ -23,6 +23,7 @@
from functools import wraps
from nose.plugins import Plugin
import subprocess
+import threading
class SlowTestsPlugin(Plugin):
@@ -88,6 +89,24 @@
StressTestsPlugin.enabled = True
+class CountThreadsPlugin(Plugin):
+ """
+ Check whether a test (or the code it triggers) leaks threads
+ """
+ name = 'countthreads'
+
+ def _thread_names(self):
+ return frozenset(t.name for t in threading.enumerate())
+
+ def startTest(self, test):
+ self._start_thread_names = self._thread_names()
+
+ def stopTest(self, test):
+ diff = self._thread_names() - self._start_thread_names
+ if diff:
+ raise Exception('thread leak: %s ' % diff)
+
+
def ValidateRunningAsRoot(f):
@wraps(f)
def wrapper(*args, **kwargs):
diff --git a/tests/testlib.py b/tests/testlib.py
index b67b377..8a55e6e 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -58,7 +58,8 @@
from virt import vmxml
from monkeypatch import Patch
-from testValidation import SlowTestsPlugin, StressTestsPlugin
+from testValidation import (
+ SlowTestsPlugin, StressTestsPlugin, CountThreadsPlugin)
# /tmp may use tempfs filesystem, not suitable for some of the test assuming a
# filesystem with direct io support.
@@ -433,6 +434,7 @@
plugins=core.DefaultPluginManager())
conf.plugins.addPlugin(SlowTestsPlugin())
conf.plugins.addPlugin(StressTestsPlugin())
+ conf.plugins.addPlugin(CountThreadsPlugin())
runner = VdsmTestRunner(stream=conf.stream,
verbosity=conf.verbosity,
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
8:20 a.m.
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: CountThreadsPlugin
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2:42 a.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-12-29 16:18:51 +0200
Line 6:
Line 7: tests: CountThreadsPlugin
Line 8:
Line 9: Enable this test plugin (via --with-countthreads) to verify that neither
Should be --with-leaked-threads
I don't quite like this
name (it sounds like the user of this WANTS leaked threads).
But I don't like my own name either, so never mind.
Line 10: your test, nor the code it tests, leak threads. Unfortunately, this
Line 11: plugin cannot be enabled by default, since we do have buggy test and
Line 12: code that do leak.
Line 13:
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
4:45 a.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
9:43 a.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-12-29 16:18:51 +0200
Line 6:
Line 7: tests: CountThreadsPlugin
Line 8:
Line 9: Enable this test plugin (via --with-countthreads) to verify that neither
what about --count-leaked-threads?
I really prefer to stick
with nose's default naming (--with-plugin-name).
Line 10: your test, nor the code it tests, leak threads. Unfortunately, this
Line 11: plugin cannot be enabled by default, since we do have buggy test and
Line 12: code that do leak.
Line 13:
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
4:09 p.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:58 a.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Enable this test plugin (via --with-thread-leak-check) to verify that
Line 10: neither your test, nor the code it tests, leak threads. Unfortunately,
Line 11: this plugin cannot be enabled by default, since we do have buggy test
Line 12: and code that do leak.
Lets be consistent with ProcessLeakChecker plugin.
shorter is
better. changing.
Line 13:
Line 14: Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
3:46 a.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
3:48 a.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Enable this test plugin (via --with-leaked-threads-check) to verify that
Line 10: neither your test, nor the code it tests, leak threads. Unfortunately,
Line 11: this plugin cannot be enabled by default, since we do have buggy test
Line 12: and code that do leak.
shorter is better. changing.
Oh, I did not notice that you
suggested to rename the class as well. I prefer to keep the Plugin suffix. Conformism is
good when it comes to naming.
Line 13:
Line 14: Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
3:51 a.m.
New subject: Change in vdsm[master]: tests: LeakedThreadsPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
5:40 a.m.
New subject: Change in vdsm[master]: tests: ThreadLeakPlugin
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 7: Code-Review-1
(3 comments)
can be that I miss some parts of this implementation?
https://gerrit.ovirt.org/#/c/69040/7/tests/testValidation.py
File tests/testValidation.py:
Line 1: #
Line 2: # Copyright 2009-2014 Red Hat, Inc.
dates
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 89: if options.enable_stress_tests:
Line 90: StressTestsPlugin.enabled = True
Line 91:
Line 92:
Line 93: class ThreadLeakPlugin(Plugin):
""" All plugins must implement the methods options(self, parser, env) and
configure(self, options, conf). Subclasses of nose.plugins.Plugin that want the standard
options should call the superclass methods. """
Line 94: """
Line 95: Check whether a test (or the code it triggers) leaks threads
Line 96: """
Line 97: name = 'thread-leak-check'
https://gerrit.ovirt.org/#/c/69040/7/tests/testlib.py
File tests/testlib.py:
Line 1: #
Line 2: # Copyright 2012-2016 Red Hat, Inc.
dates
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7:39 a.m.
New subject: Change in vdsm[master]: tests: ThreadLeakPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/7/tests/testValidation.py
File tests/testValidation.py:
Line 89: if options.enable_stress_tests:
Line 90: StressTestsPlugin.enabled = True
Line 91:
Line 92:
Line 93: class ThreadLeakPlugin(Plugin):
This does not make sense. Implementing empty method just to call the
super
this text appears under
Defining options
================
and I think it applies only to those plugins that want to define custom options. At the
moment, I see no reason to do that.
Line 94: """
Line 95: Check whether a test (or the code it triggers) leaks threads
Line 96: """
Line 97: name = 'thread-leak-check'
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7:42 a.m.
New subject: Change in vdsm[master]: tests: ThreadLeakPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7:53 a.m.
New subject: Change in vdsm[master]: tests: ThreadLeakPlugin
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
1:33 p.m.
New subject: Change in vdsm[master]: tests: ThreadLeakPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Enable this test plugin (via --with-leaked-threads-check) to verify that
Line 10: neither your test, nor the code it tests, leak threads. Unfortunately,
Line 11: this plugin cannot be enabled by default, since we do have buggy test
Line 12: and code that do leak.
We can easily rename the existing plugin classes.
In the class
name we don't have the "with" that I found misleading. ThreadLeakCheckPlugin
is fine, but so is ThreadLeakPlugin.
Line 13:
Line 14: Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
1:35 p.m.
New subject: Change in vdsm[master]: tests: ThreadLeakPlugin
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: ThreadLeakPlugin
......................................................................
Patch Set 9:
I'm happy with the current name ThreadLeakPlugin, and do not really mind
ThreadLeakCheckPlugin.
--
To view, visit https://gerrit.ovirt.org/69040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
2680
days inactive
2689
days old
vdsm-patches@lists.fedorahosted.org
15 comments
1 participants
participants (1)
-
Code Review