Change in vdsm[master]: spec: bridge-utils are required for tests

Fabian Deutsch has uploaded a new change for review.

Change subject: spec: bridge-utils are required for tests
......................................................................

spec: bridge-utils are required for tests

Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org&gt;
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/62612/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 392b071..c23cde5 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -89,6 +89,7 @@
 BuildRequires: rpm-python
 BuildRequires: python-blivet
 BuildRequires: sanlock-python
+BuildRequires: bridge-utils
 
 %if 0%{?with_openvswitch}
 BuildRequires: openvswitch >= 2.0.0
@@ -253,7 +254,6 @@
 %endif
 
 Requires: psmisc >= 22.6-15
-Requires: bridge-utils
 Requires: sos
 Requires: tree
 Requires: dosfstools


-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Sandro Bonazzola]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/62612/1/vdsm.spec.in
File vdsm.spec.in:

Line 252
Line 253
Line 254
Line 255
Line 256
aren't these also needed at runtime?


-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes

Fabian Deutsch has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
......................................................................


Patch Set 1:

Mh - Wasn't there some magiv to make it an automatic requirement if it was needed
during builds?
Or was this just for -devel packages?

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Sandro Bonazzola]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
......................................................................


Patch Set 1:

No magic automation I'm aware of.

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: spec: bridge-utils are required for tests
......................................................................


Patch Set 2: Code-Review-1

wow, a blast from the past.

since this was posted, we've dropped all TestRequires from the spec. If the package is
still needed, please add it to automation/check-patch.packages.*

-- 
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I115f7e9d01fa74c36ef535f85474ffb16177f429
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No