Change in vdsm[master]: tests: add tests for API.VM.create()

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: tests: add tests for API.VM.create()
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/67160/6/tests/API_test.py
File tests/API_test.py:

Line 44:             'memSize': 8 * 1024,
Line 45:             'vmType': 'kvm',
Line 46:             'display': 'qxl',
Line 47:             'kvmEnable': 'true',
Line 48:             'nicModel': 'rtl8139,pv',
I find it wrong to add this abomination now.

My best approach is probably to get https://gerrit.ovirt.org/#/c/67165/ verified and
merged asap; I just cannot find the time to verify it against engine and convince Piotr
that it is same.
Line 49:         }
Line 50:         with MonkeyPatchScope([(API, 'clientIF', self.cif)]):
Line 51:             self.vm = API.VM(self.uuid)
Line 52:         # to make testing easier


-- 
To view, visit https://gerrit.ovirt.org/67160
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45583c7e939627f750527f70a3edc03ccc4f0db0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes