8:12 a.m.
Peter V. Saveliev has uploaded a new change for review.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Abort VM migration on EIO by default. The flag is supported
since libvirt 1.0.1 upstream, so use getattr() to keep code
compatible with older libvirt versions. In the latter case
migration EIO abort will not work.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961154
Signed-off-by: Peter V. Saveliev <peet(a)redhat.com>
Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
---
M lib/vdsm/config.py.in
M vdsm/vm.py
2 files changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/17422/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index bdbd91a..2cb1b48 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -83,6 +83,10 @@
('migration_downtime_steps', '10',
'Incremental steps used to reach migration_downtime.'),
+ ('migration_abort_on_eio', 'true',
+ 'Abort VM migration on I/O error and refuse to migrate '
+ 'VMs, paused because of EIO.'),
+
('max_outgoing_migrations', '3',
'Maximum concurrent outgoing migrations'),
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 4333170..8a60159 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -379,12 +379,23 @@
# side
self._preparingMigrationEvt = False
if not self._migrationCanceledEvt:
+ # Note on VIR_MIGRATE_ABORT_ON_ERROR:
+ #
+ # The flag is added in libvirt-1.1.0, is available
+ # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
+ # be backported to RHEL 6.4 ever.
+ # So the solution could be a dependency in the spec-file,
+ # but this getattr() trick just let us not to do unneeded
+ # fork.
self._vm._dom.migrateToURI2(
duri, muri, None,
libvirt.VIR_MIGRATE_LIVE |
libvirt.VIR_MIGRATE_PEER2PEER |
(libvirt.VIR_MIGRATE_TUNNELLED if
- self._tunneled else 0),
+ self._tunneled else 0) |
+ (getattr(libvirt, 'VIR_MIGRATE_ABORT_ON_ERROR', 0) if
+ config.get('vars',
+ 'migration_abort_on_eio') else 0),
None, maxBandwidth)
finally:
t.cancel()
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
4:59 a.m.
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:25 p.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Abort VM migration on EIO by default. The flag is supported
since libvirt 1.0.1 upstream, so use it only in appropriate
cluster versions.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961154
Signed-off-by: Peter V. Saveliev <peet(a)redhat.com>
Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Reviewed-on: http://gerrit.ovirt.org/17422
Reviewed-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/vm.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Saggi Mizrahi: Looks good to me, but someone else must approve
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Vinzenz Feenstra: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Peter V. Saveliev: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:25 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:28 a.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:04 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:26 a.m.
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:27 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4060/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3165/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3981/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:17 a.m.
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 2:
(4 comments)
....................................................
Commit Message
Line 6:
Line 7: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Line 8:
Line 9: Abort VM migration on EIO by default. The flag is supported
Line 10: since libvirt 1.0.1 upstream, so use getattr() to keep code
Done
Line 11: compatible with older libvirt versions. In the latter case
Line 12: migration EIO abort will not work.
Line 13:
Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961154
....................................................
File vdsm/vm.py
Line 379: # we may return migration stop but it will start at libvirt
Line 380: # side
Line 381: self._preparingMigrationEvt = False
Line 382: if not self._migrationCanceledEvt:
Line 383: # Note on VIR_MIGRATE_ABORT_ON_ERROR:
Done
Line 384: #
Line 385: # The flag is added in libvirt-1.1.0, is available
Line 386: # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387: # be backported to RHEL 6.4 ever.
Line 385: # The flag is added in libvirt-1.1.0, is available
Line 386: # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387: # be backported to RHEL 6.4 ever.
Line 388: #
Line 389: # One should not supply "abort_on_eio" having old
Done
Line 390: # libvirt versions.
Line 391: self._vm._dom.migrateToURI2(
Line 392: duri, muri, None,
Line 393: libvirt.VIR_MIGRATE_LIVE |
....................................................
File vdsm_api/vdsmapi-schema.json
Line 5669: # @method: #optional
Line 5670: #
Line 5671: # @tunneled: #optional use libvirt's tunneled migration. default it
False.
Line 5672: #
Line 5673: # @abort_on_eio: #optional Abort migration on I/O errors and refuse to
migrate
Done
Line 5674: # VMs, paused due to EIO
Line 5675: #
Line 5676: # @dstqemu: #optional The destination's host address dedicated for
migration.
Line 5677: #
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
7:46 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 2: -Code-Review
(1 comment)
....................................................
File vdsm/vm.py
Line 385: # The flag is added in libvirt-1.1.0, is available
Line 386: # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387: # be backported to RHEL 6.4 ever.
Line 388: #
Line 389: # One should not supply "abort_on_eio" having old
Should be cluster level 3.3
Line 390: # libvirt versions.
Line 391: self._vm._dom.migrateToURI2(
Line 392: duri, muri, None,
Line 393: libvirt.VIR_MIGRATE_LIVE |
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
3:55 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
....................................................
Commit Message
Line 6:
Line 7: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Line 8:
Line 9: Abort VM migration on EIO by default. The flag is supported
Line 10: since libvirt 1.0.1 upstream, so use getattr() to keep code
I do not see any usage of getattr() (and I don't really want to...), so please fix the
doc.
Line 11: compatible with older libvirt versions. In the latter case
Line 12: migration EIO abort will not work.
Line 13:
Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961154
....................................................
File vdsm_api/vdsmapi-schema.json
Line 5669: # @method: #optional
Line 5670: #
Line 5671: # @tunneled: #optional use libvirt's tunneled migration. default it
False.
Line 5672: #
Line 5673: # @abort_on_eio: #optional Abort migration on I/O errors and refuse to
migrate
abortOnError is a more conventional name.
Line 5674: # VMs, paused due to EIO
Line 5675: #
Line 5676: # @dstqemu: #optional The destination's host address dedicated for
migration.
Line 5677: #
....................................................
File vdsm/vm.py
Line 379: # we may return migration stop but it will start at libvirt
Line 380: # side
Line 381: self._preparingMigrationEvt = False
Line 382: if not self._migrationCanceledEvt:
Line 383: # Note on VIR_MIGRATE_ABORT_ON_ERROR:
neither do I.
Line 384: #
Line 385: # The flag is added in libvirt-1.1.0, is available
Line 386: # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387: # be backported to RHEL 6.4 ever.
Line 385: # The flag is added in libvirt-1.1.0, is available
Line 386: # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387: # be backported to RHEL 6.4 ever.
Line 388: #
Line 389: # One should not supply "abort_on_eio" having old
So how come True is the default? You have to require that libvirt version if you want to
keep this.
Line 390: # libvirt versions.
Line 391: self._vm._dom.migrateToURI2(
Line 392: duri, muri, None,
Line 393: libvirt.VIR_MIGRATE_LIVE |
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:22 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2746/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3553/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3637/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:07 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/vm.py
Line 379: # we may return migration stop but it will start at libvirt
Line 380: # side
Line 381: self._preparingMigrationEvt = False
Line 382: if not self._migrationCanceledEvt:
Line 383: # Note on VIR_MIGRATE_ABORT_ON_ERROR:
i don't think this is needed....
Line 384: #
Line 385: # The flag is added in libvirt-1.1.0, is available
Line 386: # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387: # be backported to RHEL 6.4 ever.
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:38 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 1:
actually, making it optional and sent from engine would be preferred, similarly to
tunneled migration
- engine can drive it's use without requiring vdsm change
- no vdsm.conf required
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:31 a.m.
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File lib/vdsm/config.py.in
Line 84: 'Incremental steps used to reach migration_downtime.'),
Line 85:
Line 86: ('migration_abort_on_eio', 'true',
Line 87: 'Abort VM migration on I/O error and refuse to migrate '
Line 88: 'VMs, paused because of EIO.'),
something like "Abort VM migration on I/O error (paused due to EIO)" ?
Line 89:
Line 90: ('max_outgoing_migrations', '3',
Line 91: 'Maximum concurrent outgoing migrations'),
Line 92:
....................................................
File vdsm/vm.py
Line 385: # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 386: # be backported to RHEL 6.4 ever.
Line 387: # So the solution could be a dependency in the spec-file,
Line 388: # but this getattr() trick just let us not to do unneeded
Line 389: # fork.
why is this needed? starting _now_ it should work. F19 supports it and RHEL 6.5 as well
Line 390: self._vm._dom.migrateToURI2(
Line 391: duri, muri, None,
Line 392: libvirt.VIR_MIGRATE_LIVE |
Line 393: libvirt.VIR_MIGRATE_PEER2PEER |
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:17 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2725/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3532/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3616/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:16 p.m.
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3869
days inactive
3936
days old
vdsm-patches@lists.fedorahosted.org
16 comments
7 participants
participants (7)
-
asegurap＠redhat.com -
Dan Kenigsberg -
Jenkins CI RO -
michal.skrivanek＠redhat.com -
peet＠redhat.com -
smizrahi＠redhat.com -
Vinzenz Feenstra