Change in vdsm[master]: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR

Peter V. Saveliev has posted comments on this change.

Change subject: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
......................................................................


Patch Set 2:

(4 comments)

....................................................
Commit Message
Line 6: 
Line 7: vdsm: support VIR_MIGRATE_ABORT_ON_ERROR
Line 8: 
Line 9: Abort VM migration on EIO by default. The flag is supported
Line 10: since libvirt 1.0.1 upstream, so use getattr() to keep code
Done
Line 11: compatible with older libvirt versions. In the latter case
Line 12: migration EIO abort will not work.
Line 13: 
Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961154


....................................................
File vdsm/vm.py
Line 379:                 # we may return migration stop but it will start at libvirt
Line 380:                 # side
Line 381:                 self._preparingMigrationEvt = False
Line 382:                 if not self._migrationCanceledEvt:
Line 383:                     # Note on VIR_MIGRATE_ABORT_ON_ERROR:
Done
Line 384:                     #
Line 385:                     # The flag is added in libvirt-1.1.0, is available
Line 386:                     # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387:                     # be backported to RHEL 6.4 ever.


Line 385:                     # The flag is added in libvirt-1.1.0, is available
Line 386:                     # since libvirt-0.10.2-20.el6 in RHEL 6.5, but will not
Line 387:                     # be backported to RHEL 6.4 ever.
Line 388:                     #
Line 389:                     # One should not supply "abort_on_eio" having old
Done
Line 390:                     # libvirt versions.
Line 391:                     self._vm._dom.migrateToURI2(
Line 392:                         duri, muri, None,
Line 393:                         libvirt.VIR_MIGRATE_LIVE |


....................................................
File vdsm_api/vdsmapi-schema.json
Line 5669: # @method:     #optional
Line 5670: #
Line 5671: # @tunneled:   #optional use libvirt's tunneled migration. default it
False.
Line 5672: #
Line 5673: # @abort_on_eio:  #optional Abort migration on I/O errors and refuse to
migrate
Done
Line 5674: #                 VMs, paused due to EIO
Line 5675: #
Line 5676: # @dstqemu:    #optional The destination's host address dedicated for
migration.
Line 5677: #


-- 
To view, visit http://gerrit.ovirt.org/17422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f715c51f28ef2cd01fb95d42553ca10c79ea80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes