Change in vdsm[ovirt-3.6]: Having logrotate configuration to rotate coredump directory ...

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/48003

to review the following change.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................

Having logrotate configuration to rotate coredump directory as root user

As vdsm configures logrotate rule to rotate /var/log/core directory,
which output coredump files for all processes - such as once that runs
as root - it should perform the rotation as root user as well, otherwise
rotating libvirt coredump will be ignored with permission denied error.

This is an ancient regression introduced while fixing rhbz#772591 with
commit 951b41d.

Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1265547
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/47833
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/vdsm-logrotate.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/48003/1

diff --git a/vdsm/vdsm-logrotate.conf.in b/vdsm/vdsm-logrotate.conf.in
index ce71015..af85330 100644
--- a/vdsm/vdsm-logrotate.conf.in
+++ b/vdsm/vdsm-logrotate.conf.in
@@ -15,5 +15,5 @@
     compresscmd /usr/bin/xz
     uncompresscmd /usr/bin/unxz
     compressext .xz
-    su @VDSMUSER@ @VDSMGROUP@
+    su root root
 }


-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................


Patch Set 1:

* Update tracker::#1265547::OK
* Check Bug-Url::OK
* Check Public Bug::#1265547::OK, public bug
* Check Product::#1265547::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Yeela Kaplan has posted comments on this change.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................


Patch Set 1: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................


Having logrotate configuration to rotate coredump directory as root user

As vdsm configures logrotate rule to rotate /var/log/core directory,
which output coredump files for all processes - such as once that runs
as root - it should perform the rotation as root user as well, otherwise
rotating libvirt coredump will be ignored with permission denied error.

This is an ancient regression introduced while fixing rhbz#772591 with
commit 951b41d.

Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1265547
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/47833
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/48003
Reviewed-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
---
M vdsm/vdsm-logrotate.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yeela Kaplan: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................


Patch Set 2:

* Update tracker::#1265547::OK
* Set MODIFIED::bug 1265547::::#1265547::::IGNORE, not oVirt prod but vdsm

-- 
To view, visit https://gerrit.ovirt.org/48003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No