Dan Kenigsberg has submitted this change and it was merged.
Change subject: Having logrotate configuration to rotate coredump directory as root user
......................................................................
Having logrotate configuration to rotate coredump directory as root user
As vdsm configures logrotate rule to rotate /var/log/core directory,
which output coredump files for all processes - such as once that runs
as root - it should perform the rotation as root user as well, otherwise
rotating libvirt coredump will be ignored with permission denied error.
This is an ancient regression introduced while fixing rhbz#772591 with
commit 951b41d.
Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1265547
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/47833
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/vdsm-logrotate.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Bronhaim: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/47833
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib012f61a18c61bc0415be22f5b89ea25a58ef328
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org