Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: disable truncating diff in assert error messages
......................................................................
tests: disable truncating diff in assert error messages
Set the maximum length of a diff in failure messages by assert
methods using difflib. When diffing long dictionaries this can make
debugging easier. Also remove other specific uses of this setting.
Without this setting a failing test messege might look like this:
==============================================
FAIL: testLongDiff (netinfoTests.TestNetinfo)
-----------------------------------------------
Traceback (most recent call last):
...
self.assertEqual(first, seconds)
AssertionError: {10: 63, 11: 72, 13: 65, 16: 72[truncated]...
!= {2: 39, 3: 15, 20: 84, 37: 84, 50: 76, 53: [truncated]...
Diff is 746 characters long. Set self.maxDiff to None to see it.
----------------------------------------------------------------------
Change-Id: I70efdc56e7638ebe363453f1df4d3a520ab44f2e
Signed-off-by: Ido Barkan <ibarkan(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/42902
Continuous-Integration: Jenkins CI
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Bala.FA <barumuga(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/gluster_cli_tests.py
M tests/testlib.py
M tests/vmTests.py
3 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Bala.FA: Looks good to me, but someone else must approve
Ido Barkan: Verified
Jenkins CI: Passed CI tests
mooli tayer: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/42902
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70efdc56e7638ebe363453f1df4d3a520ab44f2e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>