mooli tayer has posted comments on this change.
Change subject: tests: disable truncating diff in assert error messages
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42902/1/tests/testlib.py
File tests/testlib.py:
Line 149: class VdsmTestCase(unittest.TestCase):
Line 150: def __init__(self, *args, **kwargs):
Line 151: unittest.TestCase.__init__(self, *args, **kwargs)
Line 152: self.log = logging.getLogger(self.__class__.__name__)
Line 153: self.maxDiff = None # disable truncating diff in assert error messages
$ git grep maxDiff
tests/gluster_cli_tests.py: maxDiff = None
tests/vmTests.py: self.maxDiff = None
Can these two be removed now?
can you explain/show what the output difference is?
Line 154:
Line 155: def retryAssert(self, *args, **kwargs):
Line 156: '''Keep retrying an assertion if AssertionError is raised.
Line 157: See function utils.retry for the meaning of the arguments.
--
To view, visit
https://gerrit.ovirt.org/42902
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70efdc56e7638ebe363453f1df4d3a520ab44f2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes