12:07 p.m.
Dima Kuznetsov has uploaded a new change for review.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
logging: Stop the fileConfig from disabling existing logs
Unless disable_existsing_loggers is passed as true, logging checks
the pre-existing logs and disables any that are not mentioned in the
configuration file, this causes various logs to be not visible.
Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060510
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
---
M vdsm/vdsm
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/25185/1
diff --git a/vdsm/vdsm b/vdsm/vdsm
index d91704a..1f72755 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -79,7 +79,7 @@
def run(pidfile=None):
- lconfig.fileConfig(loggerConfFile)
+ lconfig.fileConfig(loggerConfFile, disable_existing_loggers=False)
logging.addLevelName(5, 'TRACE')
logging.TRACE = 5 # impolite but helpful
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
12:34 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 1: Code-Review-1
oh sorry. we have more locations were we load logging.config , modify all of them
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:09 a.m.
New subject: Change in vdsm[master]: logging: Enable all loggers
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Enable all loggers
......................................................................
logging: Enable all loggers
Unless disable_existsing_loggers is passed as false, logging checks
the pre-existing logs and disables any that are not mentioned in the
configuration file, this causes various logs to be not visible.
Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060510
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25185
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/upgrade.py
M vdsm/supervdsmServer
M vdsm/ut/ivdsm.py
M vdsm/vdsm
M vdsm/vdsm-restore-net-config
M vdsm_reg/vdsm-reg-setup.in
6 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
Dima Kuznetsov: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
4:26 a.m.
New subject: Change in vdsm[master]: logging: Enable all loggers
Dima Kuznetsov has posted comments on this change.
Change subject: logging: Enable all loggers
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:59 a.m.
New subject: Change in vdsm[master]: logging: Enable all loggers
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Enable all loggers
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:19 a.m.
New subject: Change in vdsm[master]: logging: Enable all loggers
Dima Kuznetsov has posted comments on this change.
Change subject: logging: Enable all loggers
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:04 a.m.
New subject: Change in vdsm[master]: logging: Enable all loggers
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logging: Enable all loggers
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7403/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6610/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7512/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9:36 a.m.
Nir Soffer has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Title can be nicer.
http://gerrit.ovirt.org/#/c/25185/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-02-27 19:58:24 +0200
Line 4: Commit: Dima Kuznetsov <dkuznets(a)redhat.com>
Line 5: CommitDate: 2014-03-02 13:52:19 +0200
Line 6:
Line 7: logging: Stop the fileConfig from disabling existing logs
It would be nice if you refine the title:
logging: Enable all loggers
Line 8:
Line 9: Unless disable_existsing_loggers is passed as false, logging checks
Line 10: the pre-existing logs and disables any that are not mentioned in the
Line 11: configuration file, this causes various logs to be not visible.
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:16 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7382/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6591/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7493/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
6:10 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:30 a.m.
Nir Soffer has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Nice.
Did you check if there is an open bug in Python about this undocumented argument?
http://gerrit.ovirt.org/#/c/25185/2//COMMIT_MSG
Commit Message:
Line 7: logging: Stop the fileConfig from disabling existing logs
Line 8:
Line 9: Unless disable_existsing_loggers is passed as true, logging checks
Line 10: the pre-existing logs and disables any that are not mentioned in the
Line 11: configuration file, this causes various logs to be not visible.
Please mention that this is undocumented argument.
Line 12:
Line 13: Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060510
Line 15: Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
Line 19: Passed flag to keep existing loggers enabled in supervdsm as well.
Line 20:
Line 21: Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Line 22: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1060510
Line 23: Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
Please remove the duplicates messages :-)
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
1:34 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 2:
and vdsm_reg/vdsm-reg-setup.in, (and vdsm/ut/ivdsm.py if we'll one day use it). please
just verify that now we don't print some unnecessary logs from external packages that
vdsm imports
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:55 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 2:
but why not elsewhere, such as in vdsm/vdsm-restore-net-config and
lib/vdsm/tool/upgrade.py ?
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:07 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7342/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6558/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7460/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:33 p.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:17 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7340/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6556/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7458/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:10 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3731
days inactive
3737
days old
vdsm-patches@lists.fedorahosted.org
16 comments
5 participants
participants (5)
-
Dan Kenigsberg -
dkuznets＠redhat.com -
Jenkins CI RO -
Nir Soffer -
ybronhei＠redhat.com