Nir Soffer has posted comments on this change.
Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Nice.
Did you check if there is an open bug in Python about this undocumented argument?
http://gerrit.ovirt.org/#/c/25185/2//COMMIT_MSG
Commit Message:
Line 7: logging: Stop the fileConfig from disabling existing logs
Line 8:
Line 9: Unless disable_existsing_loggers is passed as true, logging checks
Line 10: the pre-existing logs and disables any that are not mentioned in the
Line 11: configuration file, this causes various logs to be not visible.
Please mention that this is undocumented argument.
Line 12:
Line 13: Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Line 14: Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1060510
Line 15: Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
Line 19: Passed flag to keep existing loggers enabled in supervdsm as well.
Line 20:
Line 21: Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Line 22: Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1060510
Line 23: Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
Please remove the duplicates messages :-)
--
To view, visit
http://gerrit.ovirt.org/25185
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes