Change in vdsm[master]: dumpStorageTable: fix path to ovf files

Derrick Ornelas has uploaded a new change for review.

Change subject: dumpStorageTable: fix path to ovf files
......................................................................

dumpStorageTable: fix path to ovf files

Change-Id: I99262e5d0ace5236ef97606a630b2bff1bd8b4c8
Signed-off-by: Derrick Ornelas <dornelas(a)redhat.com&gt;
---
M vdsm/dumpStorageTable.py.in
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/4804/1
--
To view, visit http://gerrit.ovirt.org/4804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99262e5d0ace5236ef97606a630b2bff1bd8b4c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Derrick Ornelas <dornelas(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: dumpStorageTable: fix path to ovf files
......................................................................


dumpStorageTable: fix path to ovf files

Use os.path.join() instead of string concatanation, as DC does not have
a trailing slash.

Change-Id: I99262e5d0ace5236ef97606a630b2bff1bd8b4c8
Signed-off-by: Derrick Ornelas <dornelas(a)redhat.com&gt;
---
M vdsm/dumpStorageTable.py.in
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99262e5d0ace5236ef97606a630b2bff1bd8b4c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Derrick Ornelas <dornelas(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Derrick Ornelas <dornelas(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: dumpStorageTable: fix path to ovf files
......................................................................


Patch Set 2: Verified; Looks good to me, approved

I've read a private communication with an explanation about this bug fix. Fixing
commit message accordingly.

Derrick Ornelas has also states that he had verified this patch.

--
To view, visit http://gerrit.ovirt.org/4804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99262e5d0ace5236ef97606a630b2bff1bd8b4c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Derrick Ornelas <dornelas(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Derrick Ornelas <dornelas(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: dumpStorageTable: fix path to ovf files
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 7: dumpStorageTable: fix path to ovf files
I beg your pardon, but I do not notice where is the fix.

at a cursory look, changes seemed algebraic cleanups to me. I know that I'm missing
something - please point it out to me (preferably in the commit message).

....................................................
File vdsm/dumpStorageTable.py.in
Line 26: MASTERSD_PATH = 'mastersd/master/vms'
actually, it is MASTERSD_VM_PATH, but I do not really mind.

Line 41:             vm_images_links = os.listdir(os.path.join(DC, pool, MASTERSD_PATH,
vmUUID))
while at it, it would be nicer if you break long lines.

--
To view, visit http://gerrit.ovirt.org/4804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99262e5d0ace5236ef97606a630b2bff1bd8b4c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Derrick Ornelas <dornelas(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;