4:29 a.m.
Bing Bu Cao(Mars) has uploaded a new change for review.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm. Applied this patch
set,almost all the typo in vdsm.git will be fixed.
......................................................................
Fixing typo in the source files besides vdsm.git/vdsm.
Applied this patch set,almost all the typo in vdsm.git will be fixed.
Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Signed-off-by: Cao,Bing Bu <mars(a)linux.vnet.ibm.com>
---
M tests/miscTests.py
M tests/resourceManagerTests.py
M tests/testrunner.py
M vds_bootstrap/vds_bootstrap.py
M vdsm_cli/vdsClient.py
M vdsm_hooks/floppy/before_vm_start.py
M vdsm_hooks/promisc/after_vm_start.py
M vdsm_hooks/sriov/before_vm_start.py
8 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/4338/1
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao(Mars) <mars(a)linux.vnet.ibm.com>
2:30 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm. Applied this patch
set,almost all the typo in vdsm.git will be fixed.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_hooks/sriov/before_vm_start.py
Line 49: nodeDevice.deattach()
I don't think you are correct here. please double-check any non-comment change that
you have done.
Also, please have someone run a sanity check to Verify your patch.
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12:03 a.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
Bing Bu Cao has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
9:15 a.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
Adam Litke has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:04 p.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
Dan Kenigsberg has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_hooks/sriov/before_vm_start.py
Line 21: and get its pci address, deattach it from the os, create xml
Adam's English is much better than mine, but I believe that Merriam-Webster is with
me:
http://www.merriam-webster.com/dictionary/detach
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
7:45 p.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
Bing Bu Cao has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm_hooks/sriov/before_vm_start.py
Line 21: and get its pci address, deattach it from the os, create xml
I think you are right. 'detach' is correct.
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:59 a.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
Karmit Ohayon has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
Still inconsistent spelling of detach...
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Karmit Ohayon <karmitoha(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:22 a.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
ShaoHe Feng has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Karmit Ohayon <karmitoha(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
12:41 p.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
Dan Kenigsberg has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Patch Set 5: Verified; Looks good to me, approved
Oops, I kinda missed your fixing the spelling. I suppose it's time.
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Karmit Ohayon <karmitoha(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
12:41 p.m.
New subject: Change in vdsm[master]: Fixing typo in the source files besides vdsm.git/vdsm.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
......................................................................
Fixing typo in the source files besides vdsm.git/vdsm.
Applied this patch set,the typo in vdsm.git beside vdsm directory will be fixed.
Rebased on 27 June
Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Signed-off-by: Cao,Bing Bu <mars(a)linux.vnet.ibm.com>
---
M tests/miscTests.py
M tests/resourceManagerTests.py
M tests/testrunner.py
M vds_bootstrap/vds_bootstrap.py
M vdsm_cli/vdsClient.py
M vdsm_hooks/floppy/before_vm_start.py
M vdsm_hooks/promisc/after_vm_start.py
M vdsm_hooks/sriov/before_vm_start.py
8 files changed, 16 insertions(+), 16 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44a359c565f3cd6f246244d2985823af2af39835
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Karmit Ohayon <karmitoha(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
4325
days inactive
4376
days old
vdsm-patches@lists.fedorahosted.org
9 comments
5 participants
participants (5)
-
agl＠us.ibm.com -
Dan Kenigsberg -
karmitoha＠gmail.com -
mars＠linux.vnet.ibm.com -
shaohef＠linux.vnet.ibm.com