Change in vdsm[master]: vdsm | netinfo : Return Mac of bond slaves in lower case

Genadi Chereshnya has uploaded a new change for review.

Change subject: vdsm | netinfo : Return Mac of bond slaves in lower case
......................................................................

vdsm | netinfo : Return Mac of bond slaves in lower case

getVdsCaps returns MAC of all interfaces in lower case and for bond slaves
it returned it in upper cases - fixing inconsistency

Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Bug-Url: https://bugzilla.redhat.com/1116810
Signed-off-by: Genadi Chereshnya 
---
M lib/vdsm/netinfo.py
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/31888/1

diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index a3dc2ea..9080d46 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -438,8 +438,7 @@
             if line.startswith('Slave Interface: '):
                 slave = line[len('Slave Interface: '):-1]
             if line.startswith('Permanent HW addr: '):
-                addr = line[len('Permanent HW addr: '):-1]
-                paddr[slave] = addr.upper()
+                paddr[slave] = line[len('Permanent HW addr: '):-1]
     return paddr

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm | netinfo : Return Mac of bond slaves in lower case
......................................................................

Patch Set 1:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11105/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12047/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/186... : There was an infra issue, please contact [e-mail]

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11894/ : SUCCESS

Genadi Chereshnya has posted comments on this change.

Change subject: vdsm | netinfo : Return Mac of bond slaves in lower case
......................................................................

Patch Set 1: Verified+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm | netinfo : Return Mac of bond slaves in lower case
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

Minor comment about the commit message. Other than that, the patch seems fine.

http://gerrit.ovirt.org/#/c/31888/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-08-25 12:43:46 +0300
Line 4: Commit:     Genadi Chereshnya 
Line 5: CommitDate: 2014-08-25 12:43:46 +0300
Line 6: 
Line 7: vdsm | netinfo : Return Mac of bond slaves in lower case
There's no need for the "vdsm" prefix. It's the vdsm project, so it adds nothing. Please drop the space before the colon, too.
Line 8: 
Line 9: getVdsCaps returns MAC of all interfaces in lower case and for bond slaves
Line 10: it returned it in upper cases - fixing inconsistency
Line 11:

Change in vdsm[master]: netinfo: Return Mac of bond slaves in lower case

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................

Patch Set 2: Code-Review+2

Change in vdsm[master]: netinfo: Return Mac of bond slaves in lower case

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................

netinfo: Return Mac of bond slaves in lower case

getVdsCaps returns MAC of all interfaces in lower case and for bond slaves
it returned it in upper cases - fixing inconsistency

Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Bug-Url: https://bugzilla.redhat.com/1116810
Signed-off-by: Genadi Chereshnya 
Reviewed-on: http://gerrit.ovirt.org/31888
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/netinfo.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Genadi Chereshnya: Verified
  Dan Kenigsberg: Looks good to me, approved

Change in vdsm[master]: netinfo: Return Mac of bond slaves in lower case

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................

Patch Set 3:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5765/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/130/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3924/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1789/ : FAILURE

Change in vdsm[master]: netinfo: Return Mac of bond slaves in lower case

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: netinfo: Return Mac of bond slaves in lower case
......................................................................

Patch Set 2:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11229/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12171/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/189... : There was an infra issue, please contact [e-mail]

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12018/ : SUCCESS