Change in vdsm[master]: janitorial: bindingxmlrpc: remove Python-2.6 specific code

Yeela Kaplan has uploaded a new change for review.

Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
......................................................................

janitorial: bindingxmlrpc: remove Python-2.6 specific code

Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
---
M vdsm/rpc/bindingxmlrpc.py
1 file changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/47997/1

diff --git a/vdsm/rpc/bindingxmlrpc.py b/vdsm/rpc/bindingxmlrpc.py
index c521cd8..30dbabc 100644
--- a/vdsm/rpc/bindingxmlrpc.py
+++ b/vdsm/rpc/bindingxmlrpc.py
@@ -25,7 +25,6 @@
 import libvirt
 import threading
 import re
-import sys
 
 from vdsm.password import (ProtectedPassword,
                            protect_passwords,
@@ -292,14 +291,6 @@
                 threadLocal.client = None
                 threadLocal.server = None
                 threadLocal.flowID = None
-
-            if sys.version_info[:2] == (2, 6):
-                # Override BaseHTTPServer.BaseRequestHandler implementation to
-                # avoid pointless and slow attempt to get the fully qualified
-                # host name from the client address. This method is not used
-                # any more in Python 2.7.
-                def address_string(self):
-                    return self.client_address[0]
 
         server = xmlrpc.SimpleThreadedXMLRPCServer(
             requestHandler=RequestHandler,


-- 
To view, visit https://gerrit.ovirt.org/47997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/47997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Yeela Kaplan has posted comments on this change.

Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
......................................................................


Patch Set 1: Verified+1

Verified on ovirt-3.6 branch.

-- 
To view, visit https://gerrit.ovirt.org/47997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
......................................................................


janitorial: bindingxmlrpc: remove Python-2.6 specific code

Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/47997
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com&gt;
---
M vdsm/rpc/bindingxmlrpc.py
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Yeela Kaplan: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

gerrit-hooks has posted comments on this change.

Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/47997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f296c8fb57c196bff16c884d7fca67faa0722a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No