10:30 p.m.
Mark Wu has uploaded a new change for review.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Improve the checking of mulitple direct users on an interface.
Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
---
M lib/vdsm/netinfo.py
M vdsm/configNetwork.py
2 files changed, 14 insertions(+), 33 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/14872/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 8c06c2a..1e406da 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -606,32 +606,13 @@
users.add(v)
return users
- def nicOtherUsers(self, bridge, vlan, bonding, nic):
+ def ifaceHasMultiUsers(self, iface):
"""
- Returns a list of interfaces using a nic,
- other than the specified one.
+ Checks if the interface has multiple direct users.
+ The two possible cases of mulitple users are multiple bridged or
+ bridgeless networks via vlans and one direct bridgeless network
+ with multiple network users via vlan.
+ The interface can't have multiple direct users if it's enslaved
+ to bonding or bridge directly.
"""
- if bonding:
- owner = bonding
- elif vlan:
- owner = nic + '.' + vlan
- else:
- owner = bridge
- users = self.ifaceUsers(nic)
- if bonding:
- users.update(self.bondingOtherUsers(bridge, vlan, bonding))
- users.discard(owner)
- return users
-
- def bondingOtherUsers(self, bridge, vlan, bonding):
- """
- Return a list of nics/interfaces using a bonding,
- other than the specified one.
- """
- if vlan:
- owner = bonding + '.' + vlan
- else:
- owner = bridge
- users = self.ifaceUsers(bonding)
- users.discard(owner)
- return users
+ return len(list(self.getNetworksAndVlansForIface(iface))) > 1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 2543055..ef6c66f 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -270,10 +270,10 @@
print "Bondings:", _netinfo.bondings.keys()
-def _removeUnusedNics(network, vlan, bonding, nics, configWriter):
+def _removeUnusedNics(nics, configWriter):
_netinfo = netinfo.NetInfo()
for nic in nics:
- if not _netinfo.nicOtherUsers(network, vlan, bonding, nic):
+ if not _netinfo.ifaceHasMultiUsers(nic):
ifdown(nic)
configWriter.removeNic(nic)
ifup(nic)
@@ -368,14 +368,14 @@
# The (relatively) new setupNetwork verb allows to remove a network
# defined on top of an bonding device without break the bond itself.
if implicitBonding:
- if bonding and not _netinfo.bondingOtherUsers(network, vlan, bonding):
+ if bonding and not _netinfo.ifaceHasMultiUsers(bonding):
ifdown(bonding)
configWriter.removeBonding(bonding)
- _removeUnusedNics(network, vlan, bonding, nics, configWriter)
+ _removeUnusedNics(nics, configWriter)
elif not bonding:
- _removeUnusedNics(network, vlan, bonding, nics, configWriter)
- elif not _netinfo.bondingOtherUsers(network, vlan, bonding):
+ _removeUnusedNics(nics, configWriter)
+ elif not _netinfo.ifaceHasMultiUsers(bonding):
ifdown(bonding)
configWriter.setBondingMtu(bonding, DEFAULT_MTU)
ifup(bonding)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
2:52 a.m.
Mark Wu has abandoned this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 5: Abandoned
included in the delNetwork for netmodels patch
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:29 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2564/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1741/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2637/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2517/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1690/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2588/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:34 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2446/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1615/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2516/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:31 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1615/ (3/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:28 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2516/ (2/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:23 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2446/ (1/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:05 a.m.
Giuseppe Vallarelli has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
2:56 a.m.
Mark Wu has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 230:
Line 231: def _removeUnusedNics(nics, configWriter):
Line 232: _netinfo = netinfo.NetInfo()
Line 233: for nic in nics:
Line 234: if not _netinfo.ifaceHasMultiUsers(nic):
The usage of it has been changed in the patch following this one,
http://gerrit.ovirt.org/#/c/14873/
You could find out the usage of it in http://gerrit.ovirt.org/#/c/14873/, you will find
there's not ' not _netinfo.ifaceHasMultiUsers' any more
Line 235: ifdown(nic)
Line 236: configWriter.removeNic(nic)
Line 237: ifup(nic)
Line 238:
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:32 a.m.
Giuseppe Vallarelli has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File lib/vdsm/netinfo.py
Line 605: if iface == vdict['iface']:
Line 606: users.add(v)
Line 607: return users
Line 608:
Line 609: def ifaceHasMultiUsers(self, iface):
I would reverse the check instead of ifaceHasMultiUsers I would use ifaceHasOneOrZeroUsers
(or a better name) because in netinfo you check for this using not. I find it more
readable having conditions exp without not.
Line 610: """
Line 611: Checks if the interface has multiple direct users.
Line 612: The two possible cases of mulitple users are multiple bridged or
Line 613: bridgeless networks via vlans and one direct bridgeless network
Line 614: with multiple network users via vlan.
Line 615: The interface can't have multiple direct users if it's enslaved
Line 616: to bonding or bridge directly.
Line 617: """
Line 618: return len(list(self.getNetworksAndVlansForIface(iface))) > 1
Perhaps this should be >= 1, but I'm not sure, in that case I would rename it to
ifaceHasUsers or ifaceIsUsed.
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
10:33 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2340/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1505/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2407/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:31 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2340/ (3/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:30 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1505/ (2/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:30 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2407/ (1/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:36 a.m.
Giuseppe Vallarelli has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File lib/vdsm/netinfo.py
Line 600: if iface == vdict['iface']:
Line 601: users.add(v)
Line 602: return users
Line 603:
Line 604: def ifaceHasMultiUsers(self, iface):
Mark I've added a comment on the usage of this method.
Line 605: """
Line 606: Checks if the interface has multiple direct users. It could only happen
Line 607: in the following two cases:
Line 608: --> vlan1 --> network1 (bridged or
bridgeless)
....................................................
File vdsm/configNetwork.py
Line 230:
Line 231: def _removeUnusedNics(nics, configWriter):
Line 232: _netinfo = netinfo.NetInfo()
Line 233: for nic in nics:
Line 234: if not _netinfo.ifaceHasMultiUsers(nic):
Instead of if not why if _netifo.ifaceHasZeroOrOneUser
Line 235: ifdown(nic)
Line 236: configWriter.removeNic(nic)
Line 237: ifup(nic)
Line 238:
Line 325:
Line 326: # The (relatively) new setupNetwork verb allows to remove a network
Line 327: # defined on top of an bonding device without break the bond itself.
Line 328: if implicitBonding:
Line 329: if bonding and not _netinfo.ifaceHasMultiUsers(bonding):
See comment above.
Line 330: ifdown(bonding)
Line 331: configWriter.removeBonding(bonding)
Line 332:
Line 333: _removeUnusedNics(nics, configWriter)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:15 a.m.
Mark Wu has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File lib/vdsm/netinfo.py
Line 600: if iface == vdict['iface']:
Line 601: users.add(v)
Line 602: return users
Line 603:
Line 604: def ifaceHasMultiUsers(self, iface):
@Giuseppe, all the usages of 'not ifaceHasMultiUsers' is removed in the patch of
'netmodels for delNetwork' , are you fine to keep this name?
Line 605: """
Line 606: Checks if the interface has multiple direct users. It could only happen
Line 607: in the following two cases:
Line 608: --> vlan1 --> network1 (bridged or
bridgeless)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:13 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2412/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1578/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2480/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:10 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1578/ (3/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:10 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2480/ (2/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:07 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2412/ (1/3)
--
To view, visit http://gerrit.ovirt.org/14872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4000
days inactive
4016
days old
vdsm-patches@lists.fedorahosted.org
20 comments
3 participants
participants (3)
-
gvallare＠redhat.com -
Jenkins CI RO -
wudxw＠linux.vnet.ibm.com