Mark Wu has posted comments on this change.
Change subject: Improve the checking of mulitple direct users on an interface.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 230:
Line 231: def _removeUnusedNics(nics, configWriter):
Line 232: _netinfo = netinfo.NetInfo()
Line 233: for nic in nics:
Line 234: if not _netinfo.ifaceHasMultiUsers(nic):
The usage of it has been changed in the patch following this one,
http://gerrit.ovirt.org/#/c/14873/
You could find out the usage of it in
http://gerrit.ovirt.org/#/c/14873/, you will find
there's not ' not _netinfo.ifaceHasMultiUsers' any more
Line 235: ifdown(nic)
Line 236: configWriter.removeNic(nic)
Line 237: ifup(nic)
Line 238:
--
To view, visit
http://gerrit.ovirt.org/14872
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8bc4d8ee8709f72a5746edc2d61f320ef1a2ab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server