Change in vdsm[master]: Add 'devices' key to the VM configuration.

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Add 'devices' key to the VM configuration.
......................................................................

Add 'devices' key to the VM configuration.

For old type vmParams, new 'devices' key will be created with all devices info.

Change-Id: Icf4aa449b713ecfa08b68e9ebe8c196f6d16a4e8
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 37 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/795/1
--
To view, visit http://gerrit.ovirt.org/795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf4aa449b713ecfa08b68e9ebe8c196f6d16a4e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add 'devices' key to the VM configuration.
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4aa449b713ecfa08b68e9ebe8c196f6d16a4e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Add 'devices' key to the VM configuration.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1041:                 for dev in devType:
newDevice.extend(devType)

--
To view, visit http://gerrit.ovirt.org/795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4aa449b713ecfa08b68e9ebe8c196f6d16a4e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has abandoned this change.

Change subject: Add 'devices' key to the VM configuration.
......................................................................


Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Icf4aa449b713ecfa08b68e9ebe8c196f6d16a4e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;