Change in vdsm[master]: clientIF: only warn when failing to deactivate lvs after ali...

Yeela Kaplan has uploaded a new change for review.

Change subject: clientIF: only warn when failing to deactivate lvs after alignment scan
......................................................................

clientIF: only warn when failing to deactivate lvs after alignment scan

The deactivation fails because the vm can be up when performing scan,
which means deactivate should fail when vm is up and we should only
log instead of raise.

Related to BZ#998411

Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0
Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com&gt;
---
M vdsm/clientIF.py
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/18882/1

diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 38822fe..5e20e29 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -27,6 +27,7 @@
 
 from storage.dispatcher import Dispatcher
 from storage.hsm import HSM
+from storage import storage_exception as se
 import alignmentScan
 from vdsm.config import config
 import ksm
@@ -380,7 +381,11 @@
             for line in out:
                 aligning[line.partitionName] = line.alignmentScanResult
         finally:
-            self.teardownVolumePath(drive)
+            try:
+                self.teardownVolumePath(drive)
+            except se.CannotDeactivateLogicalVolume as e:
+                self.log.warning("Cannot deactivate LVs if used by a vm: %s",
+                                 str(e))
 
         return {'status': doneCode, 'alignment': aligning}
 


-- 
To view, visit http://gerrit.ovirt.org/18882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;

Sergey Gotliv has posted comments on this change.

Change subject: clientIF: only warn when failing to deactivate lvs after alignment scan
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/clientIF.py
Line 384:             try:
Line 385:                 self.teardownVolumePath(drive)
Line 386:             except se.CannotDeactivateLogicalVolume as e:
Line 387:                 self.log.warning("Cannot deactivate LVs if used by a vm:
%s",
Line 388:                                  str(e))
I reviewed alignment scan flow again. 2 days ago I was convinced that this is the right
and the quickest way to go, but now I am convinced that its not.

teardownVolumePath doesn't throw exception, otherwise we won't return alignment
result. 

teardownVolumePath calls to teardownImage which is annotated as "@public" which
means its wrapped by Dispatcher and Protect, therefore the actual teardown is running as a
task.
Task's _run() catches exception and then reflects it as an error to the caller.
_setError() is printing that ugly exception that we see in the log.
Line 389: 
Line 390:         return {'status': doneCode, 'alignment': aligning}
Line 391: 
Line 392:     def createVm(self, vmParams):


-- 
To view, visit http://gerrit.ovirt.org/18882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: clientIF: only warn when failing to deactivate lvs after alignment scan
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4278/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3381/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4197/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Itamar Heim has abandoned this change.

Change subject: clientIF: only warn when failing to deactivate lvs after alignment scan
......................................................................


Abandoned

no reply - abandoning - please restore if still relevant

-- 
To view, visit http://gerrit.ovirt.org/18882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: clientIF: only warn when failing to deactivate lvs after alignment scan
......................................................................


Patch Set 1:

ping?

-- 
To view, visit http://gerrit.ovirt.org/18882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No