Sergey Gotliv has posted comments on this change.
Change subject: clientIF: only warn when failing to deactivate lvs after alignment scan
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File vdsm/clientIF.py
Line 384: try:
Line 385: self.teardownVolumePath(drive)
Line 386: except se.CannotDeactivateLogicalVolume as e:
Line 387: self.log.warning("Cannot deactivate LVs if used by a vm:
%s",
Line 388: str(e))
I reviewed alignment scan flow again. 2 days ago I was convinced that this is the right
and the quickest way to go, but now I am convinced that its not.
teardownVolumePath doesn't throw exception, otherwise we won't return alignment
result.
teardownVolumePath calls to teardownImage which is annotated as "@public" which
means its wrapped by Dispatcher and Protect, therefore the actual teardown is running as a
task.
Task's _run() catches exception and then reflects it as an error to the caller.
_setError() is printing that ugly exception that we see in the log.
Line 389:
Line 390: return {'status': doneCode, 'alignment': aligning}
Line 391:
Line 392: def createVm(self, vmParams):
--
To view, visit
http://gerrit.ovirt.org/18882
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e22c136d11537d3cd96815ea52ae893b97787c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes