Change in vdsm[master]: Part of create pool operation should be done under SPM lock

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Part of create pool operation should be done under SPM lock
......................................................................

Part of create pool operation should be done under SPM lock

Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
---
M vdsm/storage/sp.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/587/1
--
To view, visit http://gerrit.ovirt.org/587
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Part of create pool operation should be done under SPM lock
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/587
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Part of create pool operation should be done under SPM lock
......................................................................


Part of create pool operation should be done under SPM lock

Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
---
M vdsm/storage/sp.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Saggi Mizrahi: Looks good to me, but someone else must approve
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Verified


--
To view, visit http://gerrit.ovirt.org/587
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Saggi Mizrahi has posted comments on this change.

Change subject: Part of create pool operation should be done under SPM lock
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/587
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Part of create pool operation should be done under SPM lock
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

I'm sad that didn't have the opportunity to discuss this issue at the right time
when it was discovered (9 Nov): http://gerrit.usersys.redhat.com/1102
And then moved upstream: http://gerrit.ovirt.org/203
Anyway I believe we need it ASAP. +1

--
To view, visit http://gerrit.ovirt.org/587
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Part of create pool operation should be done under SPM lock
......................................................................


Patch Set 1: Verified

Saggi, I know that you already add this code as part of your refactoring patches. But
because it will take a time before these big patches will pushed and without this part a
lot of ruth tests are broken I want to push it now. Sorry.

--
To view, visit http://gerrit.ovirt.org/587
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I629251f48510d0808a28f2c9e76faa61daad52f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;