Change in vdsm[master]: Try and reduce the memsize of basic locking object

Saggi Mizrahi has uploaded a new change for review.

Change subject: Try and reduce the memsize of basic locking object
......................................................................

Try and reduce the memsize of basic locking object

Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
---
M vdsm/pthread.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/545/1
--
To view, visit http://gerrit.ovirt.org/545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Reduce the memsize of basic locking object

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Reduce the memsize of basic locking object
......................................................................


Reduce the memsize of basic locking object

Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
---
M vdsm/pthread.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Saggi Mizrahi: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Reduce the memsize of basic locking object

Saggi Mizrahi has posted comments on this change.

Change subject: Reduce the memsize of basic locking object
......................................................................


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Reduce the memsize of basic locking object

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Reduce the memsize of basic locking object
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Reduce the memsize of basic locking object

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Reduce the memsize of basic locking object
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Try and reduce the memsize of basic locking object
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 7: Try and reduce the memsize of basic locking object
only try?
patch seems harmless but does it help?

....................................................
File vdsm/pthread.py
Line 58:     __slots__ = ["_mutex"]
I can't imagine __slot__ changing. how about ("_mutex",) instead?

--
To view, visit http://gerrit.ovirt.org/545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

Change in vdsm[master]: Reduce the memsize of basic locking object

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Reduce the memsize of basic locking object
......................................................................


Patch Set 4: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf7f6ccd1add266683a772f5d8f64a3494b4c088
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;