Change in vdsm[master]: gluster: add server uuid into volume brick info list

Hello Ayal Baron, Bala.FA, Saggi Mizrahi, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/18492

to review the following change.

Change subject: gluster: add server uuid into volume brick info list
......................................................................

gluster: add server uuid into volume brick info list

Currently, when a node has more than one ip, the oVirt-engine fails
to map the corresponding server using the ip alone.
If we get the host uuid along with other brick details in volume info
command it will be easy for ovirt-engine to find out the
server and thereby we can avoid confusion in finding the server.

This patch provides volume brick uuid for a given brick

Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17
Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com&gt;
---
M vdsm/gluster/cli.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/18492/1

diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index bac6d1c..e466366 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -345,9 +345,11 @@
         else:
             value['transportType'] = [TransportType.TCP, TransportType.RDMA]
         value['bricks'] = []
+        value['bricksUuid'] = []
         value['options'] = {}
         for b in el.findall('bricks/brick'):
             value['bricks'].append(b.text)
+            value['bricksUuid'] += [c[1] for c in b.items() if c[0] ==
'uuid']
         for o in el.findall('options/option'):
             value['options'][o.find('name').text] =
o.find('value').text
         volumes[value['volumeName']] = value


-- 
To view, visit http://gerrit.ovirt.org/18492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Bala.FA has posted comments on this change.

Change subject: gluster: add server uuid into volume brick info list
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

....................................................
Commit Message
Line 11: If we get the host uuid along with other brick details in volume info
Line 12: command it will be easy for ovirt-engine to find out the
Line 13: server and thereby we can avoid confusion in finding the server.
Line 14: 
Line 15: This patch provides volume brick uuid for a given brick
Does this patch provide host uuid ie glusterd uuid or brick uuid?
Line 16: 
Line 17: Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17


....................................................
File vdsm/gluster/cli.py
Line 348:         value['bricksUuid'] = []
Line 349:         value['options'] = {}
Line 350:         for b in el.findall('bricks/brick'):
Line 351:             value['bricks'].append(b.text)
Line 352:             value['bricksUuid'] += [c[1] for c in b.items() if c[0] ==
'uuid']
Why can't you get the uuid driectly than looping using find/findall? Is it required to
have uuid/brick mapping?
Line 353:         for o in el.findall('options/option'):
Line 354:             value['options'][o.find('name').text] =
o.find('value').text
Line 355:         volumes[value['volumeName']] = value
Line 356:     return volumes


-- 
To view, visit http://gerrit.ovirt.org/18492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: add server uuid into volume brick info list
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4136/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3241/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4057/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Itamar Heim has abandoned this change.

Change subject: gluster: add server uuid into volume brick info list
......................................................................


Abandoned

no reply - abandoning - please restore if still relevant

-- 
To view, visit http://gerrit.ovirt.org/18492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: gluster: add server uuid into volume brick info list
......................................................................


Patch Set 1:

ping?

-- 
To view, visit http://gerrit.ovirt.org/18492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e33f9baf50f66f6120545c25b0a01a7c3b75d17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No