11:48 a.m.
Eduardo has uploaded a new change for review.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Remove block size validation from blockSD instatiation.
This check is unnecessary at this point since vdsm will
fail before if blocks are not 512 sized.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=955993
Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/14514/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 86ffb66..0c7771c 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -409,10 +409,6 @@
self.logBlkSize = 512
self.phyBlkSize = 512
- # Check that all devices in the VG have the same logical and physical
- # block sizes.
- lvm.checkVGBlockSizes(sdUUID, (self.logBlkSize, self.phyBlkSize))
-
# _extendlock is used to prevent race between
# VG extend and LV extend.
self._extendlock = threading.Lock()
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 25363dc..a196105 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2238,6 +2238,11 @@
if domType in (sd.FCP_DOMAIN, sd.ISCSI_DOMAIN):
uuids = tuple(blockSD.getStorageDomainsList())
+ logBlkSize = 512
+ phyBlkSize = 512
+ for uuid in uuids:
+ lvm.checkVGBlockSizes(uuid, (logBlkSize, phyBlkSize))
+
elif domType is sd.NFS_DOMAIN:
lPath = conObj._mountCon._getLocalPath()
self.log.debug("nfs local path: %s", lPath)
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
4:09 a.m.
New subject: Change in vdsm[master]: Remove block size validation from blockSD instantiation.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove block size validation from blockSD instantiation.
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4201/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3306/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4122/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:45 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4199/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3304/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4120/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:29 a.m.
Eduardo has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/storage/blockSD.py
Line 406: # *blkSize keys may be missing from metadata only for domains that
Line 407: # existed before the introduction of the keys.
Line 408: # Such domains supported only 512 sizes
Line 409: self.logBlkSize = 512
Line 410: self.phyBlkSize = 512
SDs will be discovered when we are connecting to the storage (the test was moved there) or
when creating a new SD on the disk which is done with luns of uniform size.
There are not other known ways to get an SD and is assumed the sizes are constant,
therefore there is no need to check it in each instantiation.
Line 411:
Line 412: # _extendlock is used to prevent race between
Line 413: # VG extend and LV extend.
Line 414: self._extendlock = threading.Lock()
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:09 p.m.
New subject: Change in vdsm[master]: Remove block size validation from blockSD instantiation.
Itamar Heim has abandoned this change.
Change subject: Remove block size validation from blockSD instantiation.
......................................................................
Abandoned
no reply - abandoning - please restore if still relevant
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:48 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2161/ (1/2)
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:05 a.m.
Ayal Baron has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 406: # *blkSize keys may be missing from metadata only for domains that
Line 407: # existed before the introduction of the keys.
Line 408: # Such domains supported only 512 sizes
Line 409: self.logBlkSize = 512
Line 410: self.phyBlkSize = 512
this change will not fix the underlying state of the PVs in the lvm cache which are not
linked to the VG, right?
Line 411:
Line 412: # _extendlock is used to prevent race between
Line 413: # VG extend and LV extend.
Line 414: self._extendlock = threading.Lock()
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:56 p.m.
Ayal Baron has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 406: # *blkSize keys may be missing from metadata only for domains that
Line 407: # existed before the introduction of the keys.
Line 408: # Such domains supported only 512 sizes
Line 409: self.logBlkSize = 512
Line 410: self.phyBlkSize = 512
Once it's removed then it's no longer an issue. Until then though, if you
don't remove/refresh it here then you're just pushing the bug to surf someplace
else in the code.
Line 411:
Line 412: # _extendlock is used to prevent race between
Line 413: # VG extend and LV extend.
Line 414: self._extendlock = threading.Lock()
....................................................
File vdsm/storage/hsm.py
Line 2240: uuids = tuple(blockSD.getStorageDomainsList())
Line 2241: logBlkSize = 512
Line 2242: phyBlkSize = 512
Line 2243: for uuid in uuids:
Line 2244: lvm.checkVGBlockSizes(uuid, (logBlkSize, phyBlkSize))
Obviously the real fix would be to support variable block size properly. Point is that
this isn't covering all bases, it just means that we'd fail early in most cases,
but not all.
Line 2245:
Line 2246: elif domType is sd.NFS_DOMAIN:
Line 2247: lPath = conObj._mountCon._getLocalPath()
Line 2248: self.log.debug("nfs local path: %s", lPath)
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:49 a.m.
Eduardo has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 406: # *blkSize keys may be missing from metadata only for domains that
Line 407: # existed before the introduction of the keys.
Line 408: # Such domains supported only 512 sizes
Line 409: self.logBlkSize = 512
Line 410: self.phyBlkSize = 512
Since I'm working just now in a patch for removing the pvs cache I see no issue
invalidating this cache here.
To much invalidates will affect negatively the performance.
This change makes this cache irrelevant, as we want.
Line 411:
Line 412: # _extendlock is used to prevent race between
Line 413: # VG extend and LV extend.
Line 414: self._extendlock = threading.Lock()
....................................................
File vdsm/storage/hsm.py
Line 2240: uuids = tuple(blockSD.getStorageDomainsList())
Line 2241: logBlkSize = 512
Line 2242: phyBlkSize = 512
Line 2243: for uuid in uuids:
Line 2244: lvm.checkVGBlockSizes(uuid, (logBlkSize, phyBlkSize))
in order to fail here and no after, in a dd operation.
The real fix will be to correct the metadata issue, adding support of multiple block
sizes.
Line 2245:
Line 2246: elif domType is sd.NFS_DOMAIN:
Line 2247: lPath = conObj._mountCon._getLocalPath()
Line 2248: self.log.debug("nfs local path: %s", lPath)
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:03 a.m.
Ayal Baron has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 2240: uuids = tuple(blockSD.getStorageDomainsList())
Line 2241: logBlkSize = 512
Line 2242: phyBlkSize = 512
Line 2243: for uuid in uuids:
Line 2244: lvm.checkVGBlockSizes(uuid, (logBlkSize, phyBlkSize))
why is this needed?
Line 2245:
Line 2246: elif domType is sd.NFS_DOMAIN:
Line 2247: lPath = conObj._mountCon._getLocalPath()
Line 2248: self.log.debug("nfs local path: %s", lPath)
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:48 a.m.
Daniel Paikov has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:17 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2222/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2161/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:13 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2222/ (2/2)
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:17 a.m.
New subject: Change in vdsm[master]: Remove block size validation from blockSD instantiation.
Itamar Heim has posted comments on this change.
Change subject: Remove block size validation from blockSD instantiation.
......................................................................
Patch Set 3:
ping?
--
To view, visit http://gerrit.ovirt.org/14514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3638
days inactive
4008
days old
vdsm-patches@lists.fedorahosted.org
13 comments
5 participants
participants (5)
-
abaron＠redhat.com -
ewarszaw＠redhat.com -
iheim＠redhat.com -
Jenkins CI RO -
paikov＠gmail.com