Eduardo has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 406: # *blkSize keys may be missing from metadata only for domains that
Line 407: # existed before the introduction of the keys.
Line 408: # Such domains supported only 512 sizes
Line 409: self.logBlkSize = 512
Line 410: self.phyBlkSize = 512
Since I'm working just now in a patch for removing the pvs cache I see no issue
invalidating this cache here.
To much invalidates will affect negatively the performance.
This change makes this cache irrelevant, as we want.
Line 411:
Line 412: # _extendlock is used to prevent race between
Line 413: # VG extend and LV extend.
Line 414: self._extendlock = threading.Lock()
....................................................
File vdsm/storage/hsm.py
Line 2240: uuids = tuple(blockSD.getStorageDomainsList())
Line 2241: logBlkSize = 512
Line 2242: phyBlkSize = 512
Line 2243: for uuid in uuids:
Line 2244: lvm.checkVGBlockSizes(uuid, (logBlkSize, phyBlkSize))
in order to fail here and no after, in a dd operation.
The real fix will be to correct the metadata issue, adding support of multiple block
sizes.
Line 2245:
Line 2246: elif domType is sd.NFS_DOMAIN:
Line 2247: lPath = conObj._mountCon._getLocalPath()
Line 2248: self.log.debug("nfs local path: %s", lPath)
--
To view, visit
http://gerrit.ovirt.org/14514
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server