Change in vdsm[master]: Move limit configuration to it's proper place

Saggi Mizrahi has uploaded a new change for review.

Change subject: Move limit configuration to it's proper place
......................................................................

Move limit configuration to it's proper place

currently limit configuration is managed part by vdsmd.init and part by
vdsm configuration. This is confusing an non standard. Putting a vdsm
configuration file in limits.d will make admins life easier when looking
to change VDSM's limits.

Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/config.py.in
A vdsm/limits.conf
M vdsm/vdsmd.init.in
5 files changed, 11 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/914/1
--
To view, visit http://gerrit.ovirt.org/914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: BZ#769502 Move limit configuration to its proper place

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#769502 Move limit configuration to its proper place
......................................................................


BZ#769502 Move limit configuration to its proper place

Currently limit configuration is managed part by vdsmd.init and part by
vdsm configuration. This is confusing an non standard. Putting a Vdsm
configuration file in limits.d will make admins life easier when looking
to change Vdsm's limits.

This may result in a surprise on upgrade - if someone has
max_open_files=nondefault on his vdsm.conf.

HOWEVER, these are very few and very technical users who could handle
(and would prefer) this sitting in limits.d

Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/config.py.in
A vdsm/limits.conf
M vdsm/vdsmd.init.in
5 files changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Move limit configuration to it's proper place
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/config.py.in
Line 128: 
this may result in surprise on upgrade path - if someone has max_open_files=nondefault on
his vdsm.conf.

HOWEVER I'm willing to accept this, since these are very few and very technical users
who could handle (and would prefer) this sitting in limits.d

Though may require a release note in the relevant bug.

--
To view, visit http://gerrit.ovirt.org/914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

Change in vdsm[master]: BZ#769502 Move limit configuration to its proper place

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#769502 Move limit configuration to its proper place
......................................................................


Patch Set 2: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;