Change in vdsm[master]: [WIP] Implement storage server connection aliasing

Saggi Mizrahi has uploaded a new change for review.

Change subject: [WIP] Implement storage server connection aliasing
......................................................................

[WIP] Implement storage server connection aliasing

Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
---
M vdsm/storage/hsm.py
M vdsm/storage/storageServer.py
2 files changed, 115 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/1693/1
--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Implement storage server connection aliasing

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Implement storage server connection aliasing
......................................................................


Patch Set 5: Looks good to me, but someone else must approve

My Ack, assume that you fix Federico's comment

--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Implement storage server connection aliasing

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Implement storage server connection aliasing
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Implement storage server connection aliasing

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Implement storage server connection aliasing
......................................................................


Implement storage server connection aliasing

This is the actual perstiance mechanism for the connection info. It
saves all the information needed to create a connection object in memory
on disk.

Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
---
M vdsm/storage/hsm.py
M vdsm/storage/storageServer.py
2 files changed, 81 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: shu ming <sming56(a)gmail.com&gt;

Change in vdsm[master]: Implement storage server connection aliasing

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Implement storage server connection aliasing
......................................................................


Patch Set 11: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: shu ming <sming56(a)gmail.com&gt;

Change in vdsm[master]: Implement storage server connection aliasing

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Implement storage server connection aliasing
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 436:                 conInfo = pickle.load(f)
What if this fails because a file is corrupted? You may want to skip it (and rename it to
something like ".con.broken"?) and continue.

--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Implement storage server connection aliasing

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Implement storage server connection aliasing
......................................................................


Patch Set 8: I would prefer that you didn't submit this

./autogen --system && make && make rpm 
returns:

PYTHONPATH=./vdsm:../vdsm /usr/bin/python ../tests/main.py
.
----------------------------------------------------------------------
Ran 1 test in 0.001s

OK
make[3]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4/tests'
make[2]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4/tests'
make[2]: Entering directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4'
make  check-local
make[3]: Entering directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4'
/usr/bin/pyflakes vdsm vdsm_cli vds_bootstrap vdsm_reg vdsm_hooks tests
vdsm/storage/storageServer.py:383: undefined name 'Lock'
make[3]: *** [check-local] Error 1
make[3]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/vdsmdevel/rpmbuild/BUILD/vdsm-4.9.4'
error: Bad exit status from /var/tmp/rpm-tmp.XIPz22 (%check)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.XIPz22 (%check)
make: *** [rpm] Error 1

--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: shu ming <sming56(a)gmail.com&gt;

Change in vdsm[master]: Implement storage server connection aliasing

Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Implement storage server connection aliasing
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 380: class IlligalAliasError(RuntimeError): pass
Illegal

I'd also prefer to see pass on a new line and an empty line between classes, but that
might be my style

--
To view, visit http://gerrit.ovirt.org/1693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: shu ming <sming56(a)gmail.com&gt;