11:24 a.m.
New patch submitted by Federico Simoncelli (fsimonce(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/896
commit dc34ed11fe964fe2cdcc89e4df7f7f96cb639332
Author: Federico Simoncelli <fsimonce(a)redhat.com>
Date: Mon Sep 5 16:25:53 2011 +0000
BZ#732914 Check libvirt connection on startup
Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index c5744e1..bb52ecb 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -112,6 +112,7 @@ class clientIF:
self.serverPort = config.get('addresses', 'management_port')
self.serverIP = self._getServerIP()
self.server = self._createXMLRPCServer()
+ self.libvirt = libvirtconnection.get(self)
self._initIRS()
try:
self.vmContainer = {}
@@ -976,9 +977,8 @@ class clientIF:
"""
Return a list of vdsm created VM's.
"""
- conn = libvirtconnection.get(self)
- domIds = conn.listDomainsID()
- vms = [conn.lookupByID(domId) for domId in domIds]
+ domIds = self.libvirt.listDomainsID()
+ vms = [self.libvirt.lookupByID(domId) for domId in domIds]
return [vm for vm in vms if self.isVDSMVm(vm)]
def _recoverVm(self, vmid):
11:42 a.m.
New subject: Change in vdsm[master]: BZ#732914 Check libvirt connection on startup
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732914 Check libvirt connection on startup
......................................................................
Patch Set 1:
Waiting verification:
https://trac.qa.lab.tlv.redhat.com/trac/integration/ticket/435
--
To view, visit http://gerrit.usersys.redhat.com/896
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3:32 p.m.
New subject: Change in vdsm[master]: BZ#732914 Check libvirt connection on startup
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732914 Check libvirt connection on startup
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
Commit Message
Line 7: BZ#732914 Check libvirt connection on startup
more exactly: establish libvirt connection on startup
crash vdsm asap if libvirt is not available.
....................................................
File vdsm/clientIF.py
Line 115: self.libvirt = libvirtconnection.get(self)
any reason this is not _private?
Line 116: self._initIRS()
I think there's a little race here. you pass `self` to libvirtconnection.get() before
all fields are defined. If prepareForshutdown is called from get() we'll see ugly
exceptions. I suppose using a plain libvirtconnection.get() will be safer and as useful to
crash __init__.
hmmm, maybe even push it to libvirtconnection.py import time.
Line 980: domIds = self.libvirt.listDomainsID()
no.
--
To view, visit http://gerrit.usersys.redhat.com/896
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4:28 a.m.
New subject: Change in vdsm[master]: BZ#732914 Establish libvirt connection on startup
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732914 Establish libvirt connection on startup
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/clientIF.py
Line 112: self._libvirt = libvirtconnection.get()
but why do you hold self._libvirt? it would work the same without it, since the connection
is cached in libvirtconnection.
--
To view, visit http://gerrit.usersys.redhat.com/896
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:14 a.m.
New subject: Change in vdsm[master]: BZ#732914 Establish libvirt connection on startup
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732914 Establish libvirt connection on startup
......................................................................
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/896
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:14 a.m.
New subject: Change in vdsm[master]: BZ#732914 Establish libvirt connection on startup
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#732914 Establish libvirt connection on startup
......................................................................
BZ#732914 Establish libvirt connection on startup
Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
---
M vdsm/clientIF.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/896
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4639
days inactive
4641
days old
vdsm-patches@lists.fedorahosted.org
5 comments
2 participants
participants (2)
-
Dan Kenigsberg -
Federico Simoncelli