Change in vdsm[master]: hostdev: fix address type for generic devices

[Martin Polednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: fix address type for generic devices
......................................................................

hostdev: fix address type for generic devices

Change 155e823f refactored some common elements of generic and
interface passthrough, but added type to address element only in case
of interface. Using default empty type led to invalid address being
generated.

Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com&gt;
---
M vdsm/virt/vmdevices/hostdevice.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/43041/1

diff --git a/vdsm/virt/vmdevices/hostdevice.py b/vdsm/virt/vmdevices/hostdevice.py
index 2817250..38b9cc4 100644
--- a/vdsm/virt/vmdevices/hostdevice.py
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -85,7 +85,10 @@
             type=CAPABILITY_TO_XML_ATTR[self._deviceParams['capability']])
         source = hostdev.appendChildWithArgs('source')
 
-        self._add_source_address(source)
+        self._add_source_address(
+            source,
+            type=CAPABILITY_TO_XML_ATTR[self._deviceParams['capability']]
+        )
 
         return hostdev
 


-- 
To view, visit https://gerrit.ovirt.org/43041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: hostdev: fix address type for generic devices
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/43041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Martin Polednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: fix address type for generic devices
......................................................................


Patch Set 1: Verified+1

Address has correct type.

-- 
To view, visit https://gerrit.ovirt.org/43041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: hostdev: fix address type for generic devices
......................................................................


Patch Set 1: Code-Review+1

seems OK (also checked code before 155e823f)

-- 
To view, visit https://gerrit.ovirt.org/43041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Martin Polednik]

Martin Polednik has abandoned this change.

Change subject: hostdev: fix address type for generic devices
......................................................................


Abandoned

Abandoning in favor of https://gerrit.ovirt.org/#/c/43042/

-- 
To view, visit https://gerrit.ovirt.org/43041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: hostdev: fix address type for generic devices
......................................................................


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/43041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9e3f801e219c6a3cb4d54a77a288bd770a3697
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No