Change in vdsm[master]: tests: skip jsonrpc tests

[Piotr Kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: tests: skip jsonrpc tests
......................................................................

tests: skip jsonrpc tests

Change-Id: Ia0dcf7b83178ac539a12b3cc6857f7dd18dd6c15
Signed-off-by: pkliczewski 
---
M tests/jsonRpcTests.py
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/42774/1

diff --git a/tests/jsonRpcTests.py b/tests/jsonRpcTests.py
index 3606bba..3a99696 100644
--- a/tests/jsonRpcTests.py
+++ b/tests/jsonRpcTests.py
@@ -22,6 +22,7 @@
 from clientIF import clientIF
 from contextlib import contextmanager
 from monkeypatch import MonkeyPatch
+from testValidation import brokentest

from testlib import VdsmTestCase as TestCaseBase, \
     expandPermutations, \
@@ -101,6 +102,7 @@
             finally:
                 client.close()

+    @brokentest
     @MonkeyPatch(clientIF, 'getInstance', getInstance)
     @permutations(PERMUTATIONS)
     def testMethodCallArgList(self, ssl, type):
@@ -117,6 +119,7 @@
                     self.assertEquals(self._callTimeout(client, "echo",
                                       (data,), CALL_ID), data)

+    @brokentest
     @MonkeyPatch(clientIF, 'getInstance', getInstance)
     @permutations(PERMUTATIONS)
     def testMethodCallArgDict(self, ssl, type):
@@ -132,6 +135,7 @@
                     self.assertEquals(self._callTimeout(client, "echo",
                                       {'text': data}, CALL_ID), data)

+    @brokentest
     @MonkeyPatch(clientIF, 'getInstance', getInstance)
     @permutations(PERMUTATIONS)
     def testMethodMissingMethod(self, ssl, type):
@@ -150,6 +154,7 @@
                     self.assertEquals(cm.exception.code,
                                       JsonRpcMethodNotFoundError().code)

+    @brokentest
     @MonkeyPatch(clientIF, 'getInstance', getInstance)
     @permutations(PERMUTATIONS)
     def testMethodBadParameters(self, ssl, type):
@@ -170,6 +175,7 @@
                     self.assertEquals(cm.exception.code,
                                       JsonRpcInternalError().code)

+    @brokentest
     @MonkeyPatch(clientIF, 'getInstance', getInstance)
     @permutations(PERMUTATIONS)
     def testMethodReturnsNullAndServerReturnsTrue(self, ssl, type):
@@ -186,6 +192,7 @@
                                             CALL_ID)
                     self.assertEquals(res, True)

+    @brokentest
     @MonkeyPatch(clientIF, 'getInstance', getInstance)
     @permutations(PERMUTATIONS)
     def testDoubleResponse(self, ssl, type):
@@ -205,6 +212,7 @@
                                             CALL_ID)
                     self.assertEquals(res, 'sent')

+    @brokentest
     @MonkeyPatch(clientIF, 'getInstance', getInstance)
     @permutations(PERMUTATIONS)
     def testSlowMethod(self, ssl, type):

[e-mail] has posted comments on this change.

Change subject: tests: skip jsonrpc tests
......................................................................

Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: skip jsonrpc tests
......................................................................

Patch Set 1: Verified+1

Verified locally that the tests are not run.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: skip jsonrpc tests
......................................................................

Patch Set 1: Code-Review-1

this would not help, as @brokentest only convert a FAIL to SKIP. It does not help regarding tests that hang forever.

To avoid those, you'd need to set NOSE_EXCLUDE properly.

[e-mail] has posted comments on this change.

Change subject: tests: skip jsonrpc tests
......................................................................

Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: skip jsonrpc tests
......................................................................

Patch Set 2: Verified+1

Verified by running local build and seeing the jsonrpc tests are excluded.

[e-mail] has posted comments on this change.

Change subject: tests: skip jsonrpc tests
......................................................................

Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found

[Piotr Kliczewski]

Piotr Kliczewski has abandoned this change.

Change subject: tests: skip jsonrpc tests
......................................................................

Abandoned

This patch is not needed anymore.