[PATCH] Filter the comps file we write on our media based on the package set. (#878985)

[Clint Savage]

On Mon, Dec 17, 2012 at 3:38 PM, Mike McLean <mikem at redhat.com> wrote:
> On 12/17/2012 03:14 PM, Bill Nottingham wrote:
>>
>> Bill Nottingham (notting at redhat.com) said:
>>>
>>> Only include groups that are specified in the kickstart. Remove any
>>> environments that use groups not on the media.
>>
>>
>> Anyone? Bueller?
>
>
> I'm not really familiar with the pungi code, but it looks sane enough to me.
> Just one comment...
>
> If the kickstart references groups that do not exist in comps, it looks like
> this will silently ignore them. I don't know what the old behavior was, but
> it might be worth reporting, e.g.
>
> if g:
>     ourgroups.append(g.groupid)
> else:
>     self.logger.info('Ignoring unknown group %s from kickstart file',
> item.name)
>

The old way was to state as much and move on if a group didn't exist.
Though sometimes it lied as the group was there and pungi still
reported it missing.

Clint