[PATCH] Filter the comps file we write on our media based on the package set. (#878985)
Bill Nottingham
notting at redhat.com
Tue Dec 18 18:40:13 UTC 2012
Mike McLean (mikem at redhat.com) said:
> On 12/17/2012 03:14 PM, Bill Nottingham wrote:
> >Bill Nottingham (notting at redhat.com) said:
> >>Only include groups that are specified in the kickstart. Remove any environments that use groups not on the media.
> >
> >Anyone? Bueller?
>
> I'm not really familiar with the pungi code, but it looks sane
> enough to me. Just one comment...
>
> If the kickstart references groups that do not exist in comps, it
> looks like this will silently ignore them. I don't know what the old
> behavior was, but it might be worth reporting, e.g.
>
> if g:
> ourgroups.append(g.groupid)
> else:
> self.logger.info('Ignoring unknown group %s from kickstart
> file', item.name)
This filtering is when writing the comps file out to the media - there
should already be logging on the compose path earlier when a kickstart
references a group that doesn't exist.
Bill
More information about the buildsys
mailing list